Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-09-19 Thread Jim Murphy
On Tue, Sep 19, 2017 at 7:17 PM, Tan, Jianfeng wrote: > Hi Jim, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jim Murphy > > Sent: Wednesday, September 20, 2017 6:24 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-09-19 Thread Tan, Jianfeng
Hi Jim, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jim Murphy > Sent: Wednesday, September 20, 2017 6:24 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit > system > > Hi, >

[dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-09-19 Thread Jim Murphy
Hi, The fix contained in this patch breaks under the following scenario: 1. A 64 bit host and virtual machine. Therefore all physical addresses are 64 bits. 2. A 32 bit user mode DPDK process running on a 64 bit virtual machine (64 bit kernel). In this case, the physical address is 64bits but th

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-04-18 Thread Yuanhan Liu
On Wed, Apr 19, 2017 at 06:21:59AM +, Tan, Jianfeng wrote: > > > > I've expected it to be plain english, something like following: > > > > /* > > * Return the physical address (or virtual address in case of > > * virtio-user) of mbuf data buffer. > > * > > * The addre

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-04-18 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, April 19, 2017 1:54 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; olivier.m...@6wind.com; sta...@dpdk.org > Subject: Re: [PATCH v2] net/virtio-user: fix not working on 32-bit system > > On Wed,

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-04-18 Thread Yuanhan Liu
On Wed, Apr 19, 2017 at 02:30:33AM +, Jianfeng Tan wrote: > virtio-user cannot work on 32-bit system as higher 32-bit of the > addr field (64-bit) in the desc is filled with non-zero value > which should not happen for a 32-bit system. > > In case of virtio-user, we use buf_addr of mbuf to fil

[dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-04-18 Thread Jianfeng Tan
virtio-user cannot work on 32-bit system as higher 32-bit of the addr field (64-bit) in the desc is filled with non-zero value which should not happen for a 32-bit system. In case of virtio-user, we use buf_addr of mbuf to fill the virtqueue desc addr. This is a regression bug. For 32-bit system,