Re: [dpdk-dev] [PATCH v2] net/virtio: support to turn on/off traffic flow

2017-04-26 Thread Maxime Coquelin
On 04/26/2017 09:56 AM, Yuanhan Liu wrote: On Wed, Apr 26, 2017 at 09:45:42AM +0200, Maxime Coquelin wrote: As said, only cosmetic comments, it looks otherwise valid to me. If you fix these, feel free to add my: Acked-by: Maxime Coquelin Oops, I forgot to reply this thread, that I have alre

Re: [dpdk-dev] [PATCH v2] net/virtio: support to turn on/off traffic flow

2017-04-26 Thread Yuanhan Liu
On Wed, Apr 26, 2017 at 09:45:42AM +0200, Maxime Coquelin wrote: > As said, only cosmetic comments, it looks otherwise valid to me. > If you fix these, feel free to add my: > Acked-by: Maxime Coquelin Oops, I forgot to reply this thread, that I have already applied it :/ --yliu

Re: [dpdk-dev] [PATCH v2] net/virtio: support to turn on/off traffic flow

2017-04-26 Thread Maxime Coquelin
On 04/19/2017 08:29 AM, Zhiyong Yang wrote: Current virtio_dev_stop only disables interrupt and marks link down, When it is invoked, tx/rx traffic flows still work. This is a strange behavior. The patch supports the switch of flow. Signed-off-by: Zhiyong Yang --- Changes in V2: Use the flag

[dpdk-dev] [PATCH v2] net/virtio: support to turn on/off traffic flow

2017-04-18 Thread Zhiyong Yang
Current virtio_dev_stop only disables interrupt and marks link down, When it is invoked, tx/rx traffic flows still work. This is a strange behavior. The patch supports the switch of flow. Signed-off-by: Zhiyong Yang --- Changes in V2: Use the flag "started" introduced by yuanhan's applied patch,