Re: [dpdk-dev] [PATCH v2] net/virtio: fix rxq intr config fails using vfio-pci

2017-11-08 Thread Tan, Jianfeng
On 11/9/2017 10:11 AM, Yang, Zhiyong wrote: Hi Jianfeng, -Original Message- From: Tan, Jianfeng Sent: Wednesday, November 8, 2017 9:53 PM To: Yang, Zhiyong ; dev@dpdk.org Cc: y...@fridaylinux.org; maxime.coque...@redhat.com Subject: Re: [PATCH v2] net/virtio: fix rxq intr config fails

Re: [dpdk-dev] [PATCH v2] net/virtio: fix rxq intr config fails using vfio-pci

2017-11-08 Thread Yang, Zhiyong
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, November 8, 2017 9:53 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: y...@fridaylinux.org; maxime.coque...@redhat.com > Subject: Re: [PATCH v2] net/virtio: fix rxq intr config fails using vfio-pci > > > Hi Zhiyong, >

Re: [dpdk-dev] [PATCH v2] net/virtio: fix rxq intr config fails using vfio-pci

2017-11-08 Thread Yang, Zhiyong
Hi Jianfeng, Thanks for detailed reviews and comments. Next version will come soon according to your suggestions. Thanks Zhiyong > -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, November 8, 2017 9:53 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: y...@fridaylinux.org; maxime.c

Re: [dpdk-dev] [PATCH v2] net/virtio: fix rxq intr config fails using vfio-pci

2017-11-08 Thread Tan, Jianfeng
Hi Zhiyong, On 11/8/2017 7:03 PM, Zhiyong Yang wrote: When running l3fwd-power to test virtio rxq interrupt using vfio pci noiommu mode, startup fails. In the function virtio_read_caps, the code if (flags & PCI_MSIX_ENABLE) intends to double check if vfio msix is enabled or not. However, it is

[dpdk-dev] [PATCH v2] net/virtio: fix rxq intr config fails using vfio-pci

2017-11-08 Thread Zhiyong Yang
When running l3fwd-power to test virtio rxq interrupt using vfio pci noiommu mode, startup fails. In the function virtio_read_caps, the code if (flags & PCI_MSIX_ENABLE) intends to double check if vfio msix is enabled or not. However, it is not enable at that stage. So use_msix is assigned to "0",