Re: [dpdk-dev] [PATCH v2] net/vhost: fix vhost invalid state

2018-04-11 Thread Chen, Junjie J
Hi Jianfeng. > On 4/11/2018 4:35 PM, Chen, Junjie J wrote: > >> > >> On 4/11/2018 6:53 PM, Junjie Chen wrote: > >>> dev_start sets *dev_attached* after setup queues, this sets device > >>> to invalid state since no frontend is attached. Also destroy_device > >>> set > >>> *started* to zero which m

Re: [dpdk-dev] [PATCH v2] net/vhost: fix vhost invalid state

2018-04-11 Thread Jens Freimann
On Wed, Apr 11, 2018 at 06:53:13AM -0400, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero which makes *allow_queuing* always zero until dev_start get called again. Actua

Re: [dpdk-dev] [PATCH v2] net/vhost: fix vhost invalid state

2018-04-11 Thread Tan, Jianfeng
On 4/11/2018 4:35 PM, Chen, Junjie J wrote: On 4/11/2018 6:53 PM, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero which makes *allow_queuing* always zero until dev_s

Re: [dpdk-dev] [PATCH v2] net/vhost: fix vhost invalid state

2018-04-11 Thread Chen, Junjie J
> > > On 4/11/2018 6:53 PM, Junjie Chen wrote: > > dev_start sets *dev_attached* after setup queues, this sets device to > > invalid state since no frontend is attached. Also destroy_device set > > *started* to zero which makes *allow_queuing* always zero until > > dev_start get called again. Act

Re: [dpdk-dev] [PATCH v2] net/vhost: fix vhost invalid state

2018-04-11 Thread Tan, Jianfeng
On 4/11/2018 6:53 PM, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero which makes *allow_queuing* always zero until dev_start get called again. Actually, we should not

[dpdk-dev] [PATCH v2] net/vhost: fix vhost invalid state

2018-04-10 Thread Junjie Chen
dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero which makes *allow_queuing* always zero until dev_start get called again. Actually, we should not determine queues existence by *dev_attached*