Re: [dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability

2018-02-16 Thread Thomas Monjalon
15/02/2018 22:55, Stephen Hemminger: > On Tue, 13 Feb 2018 17:35:20 +0100 > Thomas Monjalon wrote: > > > 13/02/2018 09:14, Ophir Munk: > > > CRC stripping is executed in the kernel outside of TAP PMD scope. > > > There is no prevention that the TAP PMD will report on Rx CRC > > > stripping capabi

Re: [dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability

2018-02-15 Thread Stephen Hemminger
On Tue, 13 Feb 2018 17:35:20 +0100 Thomas Monjalon wrote: > 13/02/2018 09:14, Ophir Munk: > > CRC stripping is executed in the kernel outside of TAP PMD scope. > > There is no prevention that the TAP PMD will report on Rx CRC > > stripping capability. > > In the corrupted code, TAP PMD did not re

Re: [dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability

2018-02-13 Thread Thomas Monjalon
13/02/2018 09:14, Ophir Munk: > CRC stripping is executed in the kernel outside of TAP PMD scope. > There is no prevention that the TAP PMD will report on Rx CRC > stripping capability. > In the corrupted code, TAP PMD did not report on this capability. > The fix enables TAP PMD to report that Rx C

[dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability

2018-02-13 Thread Ophir Munk
CRC stripping is executed in the kernel outside of TAP PMD scope. There is no prevention that the TAP PMD will report on Rx CRC stripping capability. In the corrupted code, TAP PMD did not report on this capability. The fix enables TAP PMD to report that Rx CRC stripping is supported. Fixes: 02f96