[dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check

2016-11-02 Thread Fulvio Risso
Dear Ferruh, Maybe I'm wrong, but I cannot see your point. The code is absolutely the same, only the following line if (eth_dev->data) { is actually removed. fulvio On 02/11/2016 12:38, Ferruh Yigit wrote: > Hi Mauricio, > > On 11/1/2016 7:55 PM, Mauricio Vasquez B wrote: >> Cover

[dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check

2016-11-02 Thread Ferruh Yigit
On 11/2/2016 12:49 PM, Fulvio Risso wrote: > Dear Ferruh, > Maybe I'm wrong, but I cannot see your point. > The code is absolutely the same, only the following line > > if (eth_dev->data) { > > is actually removed. Please double check the condition "rx_queues" freed: before the patch: =

[dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check

2016-11-02 Thread Ferruh Yigit
Hi Mauricio, On 11/1/2016 7:55 PM, Mauricio Vasquez B wrote: > Coverity detected this as an issue because internals->data will never be NULL, > then the check is not necessary. > > Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") > Coverity issue: 137873 > > Signed-off-by: Mauricio V

[dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check

2016-11-02 Thread Mauricio Vasquez
Dear Ferruh, You are right, I messed up the brackets. I already sent v3. Thanks, Mauricio. On 11/02/2016 08:15 AM, Ferruh Yigit wrote: > On 11/2/2016 12:49 PM, Fulvio Risso wrote: >> Dear Ferruh, >> Maybe I'm wrong, but I cannot see your point. >> The code is absolutely the same, only the fo

[dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check

2016-11-01 Thread Mauricio Vasquez B
Coverity detected this as an issue because internals->data will never be NULL, then the check is not necessary. Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") Coverity issue: 137873 Signed-off-by: Mauricio Vasquez B --- drivers/net/ring/rte_eth_ring.c | 20 +--- 1