Re: [dpdk-dev] [PATCH v2] net/pcap: truncate packet if it is too large

2019-12-09 Thread Ferruh Yigit
On 12/9/2019 11:26 AM, Ferriter, Cian wrote: <...> > >> -Original Message- >> From: Zhike Wang >> Sent: Monday 9 December 2019 01:53 >> To: dev@dpdk.org >> Cc: wangzh...@jd.com; Yigit, Ferruh ; Ferriter, Cian >> ; Zhike Wang >> Subject: [PATCH v2] net/pcap: truncate packet if it is too

Re: [dpdk-dev] [PATCH v2] net/pcap: truncate packet if it is too large

2019-12-09 Thread Ferriter, Cian
Hi Zhike, I've tested the behavior before and after this patch and can verify that the packets are being correctly truncated. Code looks good to me too. Reviewed-by: Cian Ferriter Thanks, Cian > -Original Message- > From: Zhike Wang > Sent: Monday 9 December 2019 01:53 > To: dev@dpd

[dpdk-dev] [PATCH v2] net/pcap: truncate packet if it is too large

2019-12-08 Thread Zhike Wang
From: Zhike Wang Previously large packet would be dropped, instead now it is better to keep it via truncating it. Signed-off-by: Zhike Wang --- drivers/net/pcap/rte_eth_pcap.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c