Re: [dpdk-dev] [PATCH v2] net/mlx5: fix potential unreleased lock problem

2021-08-30 Thread Slava Ovsiienko
Hi, Chengfeng Thank you for the fix, we can adopt this (ie Upstream ML is not "wrong place" 😊) I have some minor comment about: - the problem should be described in past tense (should b e"sh->txpp.mutex WAS not correctly") - headline should be more specific, like "fix mutex unlock in txpp cleanup

[dpdk-dev] [PATCH v2] net/mlx5: fix potential unreleased lock problem

2021-08-26 Thread Chengfeng Ye
The lock sh->txpp.mutex isn't correctly released if the function return in these two branches, which may lead to deadlock if the lock is acquired again. Cc: cy...@connect.ust.hk Bugzilla ID: 774 Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 6 +- 1 file changed, 5 insertion

[dpdk-dev] [PATCH v2] net/mlx5: fix potential unreleased lock problem

2021-08-26 Thread Chengfeng Ye
The lock sh->txpp.mutex isn't correctly released if the function return in these two branches, which may lead to deadlock if the lock is acquired again. Cc: cy...@connect.ust.hk Bugzilla ID: 774 Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 6 +- 1 file changed, 5 insertion