Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 01:17:30PM +0800, Lu, Wenzhuo wrote: > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, February 6, 2017 12:57 PM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_e

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Lu, Wenzhuo
> -Original Message- > From: Bie, Tiwei > Sent: Monday, February 6, 2017 12:57 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > On Mon, Feb 06, 2017 at 11:45:41AM +0800, Lu, Wen

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 11:45:41AM +0800, Lu, Wenzhuo wrote: > Hi Tiwei, > > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, February 6, 2017 11:08 AM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Lu, Wenzhuo
Hi Tiwei, > -Original Message- > From: Bie, Tiwei > Sent: Monday, February 6, 2017 11:08 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > On Mon, Feb 06, 2017 at 10:59:42AM +0800, Lu, Wen

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 10:59:42AM +0800, Lu, Wenzhuo wrote: > Hi Tiwei, > > > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, February 6, 2017 10:51 AM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Lu, Wenzhuo
Hi Tiwei, > -Original Message- > From: Bie, Tiwei > Sent: Monday, February 6, 2017 10:51 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > On Mon, Feb 06, 2017 at 10:41:28AM +0800, Lu, Wen

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 10:41:28AM +0800, Lu, Wenzhuo wrote: > Hi Tiwei, > > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, February 6, 2017 10:31 AM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Lu, Wenzhuo
Hi Tiwei, > -Original Message- > From: Bie, Tiwei > Sent: Monday, February 6, 2017 10:31 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > On Mon, Feb 06, 2017 at 10:09:32AM

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 10:09:32AM +0800, Wenzhuo Lu wrote: [...] > static void ixgbe_dcb_init(struct ixgbe_hw *hw, struct ixgbe_dcb_config > *dcb_config); > -static int is_ixgbe_pmd(const char *driver_name); > +static int is_device_supported(struct rte_eth_dev *dev, struct eth_driver > *drv); >

[dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Wenzhuo Lu
It's not appropriate to call rte_eth_dev_info_get in PMD, as rte_eth_dev_info_get need to get info from PMD. Remove rte_eth_dev_info_get from PMD code and get the info directly. Signed-off-by: Wenzhuo Lu --- v2: - change is_ixgbe_pmd to is_device_supported to make it more generic. drivers/net/i