Re: [dpdk-dev] [PATCH v2] net/ice: optimize protocol extraction by dynamic mbuf API

2019-10-30 Thread Wang, Haiyue
Hi Olivier, Very appreciate your response, please see reply below. > -Original Message- > From: Olivier Matz > Sent: Thursday, October 31, 2019 00:56 > To: Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ice: optimize protocol extraction by

Re: [dpdk-dev] [PATCH v2] net/ice: optimize protocol extraction by dynamic mbuf API

2019-10-30 Thread Olivier Matz
Hi Haiyue, Please see some comments below. On Tue, Oct 29, 2019 at 03:34:48PM +0800, Haiyue Wang wrote: > The original design is to use rte_mbuf::udata64 to save the metadata of > protocol extraction which has network protocol data fields and type, an nit: an -> a > private API is used to decod

[dpdk-dev] [PATCH v2] net/ice: optimize protocol extraction by dynamic mbuf API

2019-10-29 Thread Haiyue Wang
The original design is to use rte_mbuf::udata64 to save the metadata of protocol extraction which has network protocol data fields and type, an private API is used to decode this metadata. It is not so generic. Use the new dynamic mbuf field and flags to handle protocol extraction. Then the metada