Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size

2019-10-29 Thread Min, JiaqiX
Hi, Xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, October 29, 2019 1:07 PM > To: Min, JiaqiX > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size > > On 10/29, Min, JiaqiX wrote: > >Hi Xiaolong,

Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size

2019-10-28 Thread Ye Xiaolong
On 10/29, Min, JiaqiX wrote: >Hi Xiaolong, > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Monday, October 28, 2019 4:46 PM >> To: Min, JiaqiX >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix setting

Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size

2019-10-28 Thread Min, JiaqiX
Hi Xiaolong, > -Original Message- > From: Ye, Xiaolong > Sent: Monday, October 28, 2019 4:46 PM > To: Min, JiaqiX > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size > > On 10/28, Min JiaqiX wrote: > &g

Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size

2019-10-28 Thread Ye Xiaolong
On 10/28, Ye Xiaolong wrote: >Reviewed-by: Xiaolong Ye > >Applied to dpdk-next-net-intel. Thanks. Sorry for the above misleading message, this patch is still under discussion, not merged yet. Thanks, Xiaolong

Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size

2019-10-28 Thread Ye Xiaolong
On 10/28, Min JiaqiX wrote: >Max frame size is not set to HW, so packets above the MTU >do not get dropped by HW. The patch fixed the issue. > >Fixes: ae2bdd0219cb ("net/ice: support MTU setting") We should set max frame size to HW in the beginning when the driver was introduced, so the fix commi

[dpdk-dev] [PATCH v2] net/ice: fix setting max frame size

2019-10-28 Thread Min JiaqiX
Max frame size is not set to HW, so packets above the MTU do not get dropped by HW. The patch fixed the issue. Fixes: ae2bdd0219cb ("net/ice: support MTU setting") Cc: sta...@dpdk.org Signed-off-by: Min JiaqiX --- v2: * Changed commit message. --- drivers/net/ice/ice_ethdev.c | 4 1 file c