Re: [dpdk-dev] [PATCH v2] net/i40e: new API to add VF MAC address from PF

2017-08-17 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, August 17, 2017 9:05 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Stephen Hurd ; Ajit Khaparde > > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: new API to a

Re: [dpdk-dev] [PATCH v2] net/i40e: new API to add VF MAC address from PF

2017-08-17 Thread Ferruh Yigit
On 7/25/2017 3:09 PM, Wenzhuo Lu wrote: > Currently, on i40e the parameter 'pool' of API > rte_eth_dev_mac_addr_add means the VMDq pool, not VF. The argument "pool" in rte_eth_dev_mac_addr_add() IS VMDq pool. This is not just for i40e, this is by API definition. > So, it's wrong to use it to set

[dpdk-dev] [PATCH v2] net/i40e: new API to add VF MAC address from PF

2017-07-25 Thread Wenzhuo Lu
Currently, on i40e the parameter 'pool' of API rte_eth_dev_mac_addr_add means the VMDq pool, not VF. So, it's wrong to use it to set the VF MAC address. As this API is also used by the VMDq example, ideally we need a parameter to tell the pool is VMDq or VF. But it's hard to change it because of th