Re: [dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC address on i40evf

2018-01-07 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei > Sent: Thursday, January 4, 2018 3:40 PM > To: Olivier Matz; dev@dpdk.org; Wu, Jingjing > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC a

Re: [dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC address on i40evf

2018-01-03 Thread Xing, Beilei
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Wednesday, January 3, 2018 9:34 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix setting of MAC address on i40evf > > When setting the MAC addre

[dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC address on i40evf

2018-01-03 Thread Olivier Matz
When setting the MAC address, the ethdev layer copies the new mac address in dev->data->mac_addrs[0] before calling the dev_ops. Therefore, "is_same_ether_addr(mac_addr, dev->data->mac_addrs)" was always true, and the MAC was never set. Remove this test to fix the issue. Fixes: 943c2d899a0c ("net