Re: [dpdk-dev] [PATCH v2] net/i40e: Eliminate weak symbols in i40e_rxtx.c

2019-06-06 Thread Ferruh Yigit
...@intel.com >> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: Eliminate weak symbols in >> i40e_rxtx.c >> >> On 5/16/2019 3:08 PM, Bruce Richardson wrote: >>> On Wed, May 15, 2019 at 12:13:46PM -0400, David Harton wrote: >>>> Use of weak symbols can hide makef

Re: [dpdk-dev] [PATCH v2] net/i40e: Eliminate weak symbols in i40e_rxtx.c

2019-06-04 Thread Bruce Richardson
On Tue, Jun 04, 2019 at 04:59:47PM +0100, Ferruh Yigit wrote: > On 5/16/2019 3:08 PM, Bruce Richardson wrote: > > On Wed, May 15, 2019 at 12:13:46PM -0400, David Harton wrote: > >> Use of weak symbols can hide makefile errors especially when > >> custom makefiles are used. Removing the use of weak

Re: [dpdk-dev] [PATCH v2] net/i40e: Eliminate weak symbols in i40e_rxtx.c

2019-06-04 Thread David Harton (dharton)
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, June 04, 2019 12:00 PM > To: Bruce Richardson ; David Harton (dharton) > > Cc: dev@dpdk.org; beilei.x...@intel.com; qi.z.zh...@intel.com > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: Eliminate weak sym

Re: [dpdk-dev] [PATCH v2] net/i40e: Eliminate weak symbols in i40e_rxtx.c

2019-06-04 Thread Ferruh Yigit
On 5/16/2019 3:08 PM, Bruce Richardson wrote: > On Wed, May 15, 2019 at 12:13:46PM -0400, David Harton wrote: >> Use of weak symbols can hide makefile errors especially when >> custom makefiles are used. Removing the use of weak symbols >> to avoid a stub function being linked in production code.

Re: [dpdk-dev] [PATCH v2] net/i40e: Eliminate weak symbols in i40e_rxtx.c

2019-05-16 Thread Bruce Richardson
On Wed, May 15, 2019 at 12:13:46PM -0400, David Harton wrote: > Use of weak symbols can hide makefile errors especially when > custom makefiles are used. Removing the use of weak symbols > to avoid a stub function being linked in production code. > > Signed-off-by: David Harton > --- > > v2 - a

[dpdk-dev] [PATCH v2] net/i40e: Eliminate weak symbols in i40e_rxtx.c

2019-05-15 Thread David Harton
Use of weak symbols can hide makefile errors especially when custom makefiles are used. Removing the use of weak symbols to avoid a stub function being linked in production code. Signed-off-by: David Harton --- v2 - added CC_AVX2_SUPPORT check to code enabling avx2 vectors drivers/net/i40e/Ma