Re: [dpdk-dev] [PATCH v2] net/bonding: fix update link status on slave add

2018-06-01 Thread Radu Nicolau
On 5/31/2018 5:32 PM, Ferruh Yigit wrote: On 5/31/2018 5:13 PM, Radu Nicolau wrote: On 5/31/2018 4:36 PM, Ferruh Yigit wrote: On 5/31/2018 4:34 PM, Ferruh Yigit wrote: On 5/31/2018 3:34 PM, Radu Nicolau wrote: I can see you just prefix "fix" to the title without updating it :) What about

Re: [dpdk-dev] [PATCH v2] net/bonding: fix update link status on slave add

2018-05-31 Thread Ferruh Yigit
On 5/31/2018 5:13 PM, Radu Nicolau wrote: > > > On 5/31/2018 4:36 PM, Ferruh Yigit wrote: >> On 5/31/2018 4:34 PM, Ferruh Yigit wrote: >>> On 5/31/2018 3:34 PM, Radu Nicolau wrote: >>> >>> I can see you just prefix "fix" to the title without updating it :) >>> >>> What about following one: >>> "n

Re: [dpdk-dev] [PATCH v2] net/bonding: fix update link status on slave add

2018-05-31 Thread Radu Nicolau
On 5/31/2018 4:36 PM, Ferruh Yigit wrote: On 5/31/2018 4:34 PM, Ferruh Yigit wrote: On 5/31/2018 3:34 PM, Radu Nicolau wrote: I can see you just prefix "fix" to the title without updating it :) What about following one: "net/bonding: fix slave add for mode 4" ? Great, I'll use it for v3 :)

Re: [dpdk-dev] [PATCH v2] net/bonding: fix update link status on slave add

2018-05-31 Thread Ferruh Yigit
On 5/31/2018 4:34 PM, Ferruh Yigit wrote: > On 5/31/2018 3:34 PM, Radu Nicolau wrote: > > I can see you just prefix "fix" to the title without updating it :) > > What about following one: > "net/bonding: fix slave add for mode 4" ? > >> Add a call to rte_eth_link_get_nowait on every slave to upd

Re: [dpdk-dev] [PATCH v2] net/bonding: fix update link status on slave add

2018-05-31 Thread Ferruh Yigit
On 5/31/2018 3:34 PM, Radu Nicolau wrote: I can see you just prefix "fix" to the title without updating it :) What about following one: "net/bonding: fix slave add for mode 4" ? > Add a call to rte_eth_link_get_nowait on every slave to update > the internal link status struct. Otherwise slave ad

[dpdk-dev] [PATCH v2] net/bonding: fix update link status on slave add

2018-05-31 Thread Radu Nicolau
Add a call to rte_eth_link_get_nowait on every slave to update the internal link status struct. Otherwise slave add will fail for mode 4 if the ports are all stopped but only one of them checked. Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions") Bugzilla entry: https://dpdk.