Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

2018-06-18 Thread Ferruh Yigit
On 6/13/2018 5:10 PM, Ferruh Yigit wrote: > On 2/12/2018 6:26 PM, Chas Williams wrote: >> It's not clear to me that link_properties_valid() is even correct.  Nothing >> prevents an adapter from later negotiating a lower speed and would fail this >> test.  If both adapters are set to autoneg, that s

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

2018-06-13 Thread Ferruh Yigit
On 2/12/2018 6:26 PM, Chas Williams wrote: > It's not clear to me that link_properties_valid() is even correct.  Nothing > prevents an adapter from later negotiating a lower speed and would fail this > test.  If both adapters are set to autoneg, that should be sufficient but > nothing enforces the

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

2018-02-16 Thread Stephen Hemminger
On Wed, 29 Nov 2017 16:42:00 +0100 Tomasz Kulasek wrote: > + /* Some devices needs more time to initialize and bring interface up. > + * While link status up is preferable we wait some time to be sure that > + * link status of slave is valid. > + */ > + if (slave_eth_dev->d

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

2018-02-12 Thread Chas Williams
It's not clear to me that link_properties_valid() is even correct. Nothing prevents an adapter from later negotiating a lower speed and would fail this test. If both adapters are set to autoneg, that should be sufficient but nothing enforces the speed match after the slaves are configured. So wh

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

2018-02-06 Thread Thomas Monjalon
17/01/2018 17:02, Ferruh Yigit: > On 11/29/2017 3:42 PM, Tomasz Kulasek wrote: > > Some devices needs more time to initialize and bring interface up. When > > link is down the link properties are not valid, e.g. link_speed is > > reported as 0 and this is not a valid speed for slave as well as for

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

2018-01-17 Thread Ferruh Yigit
On 11/29/2017 3:42 PM, Tomasz Kulasek wrote: > Some devices needs more time to initialize and bring interface up. When > link is down the link properties are not valid, e.g. link_speed is > reported as 0 and this is not a valid speed for slave as well as for whole > bonding. > > During NIC (and bo

[dpdk-dev] [PATCH v2] net/bonding: fix link status check

2017-11-29 Thread Tomasz Kulasek
Some devices needs more time to initialize and bring interface up. When link is down the link properties are not valid, e.g. link_speed is reported as 0 and this is not a valid speed for slave as well as for whole bonding. During NIC (and bonding) initialization there's concurrency between updatin