Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-07-04 Thread Ferruh Yigit
On 4/16/2019 4:13 PM, Bruce Richardson wrote: > On Tue, Apr 16, 2019 at 08:03:36AM -0700, Stephen Hemminger wrote: >> On Tue, 16 Apr 2019 10:42:13 +0100 >> Bruce Richardson wrote: >> >>> On Tue, Apr 16, 2019 at 10:37:07AM +0100, Ferruh Yigit wrote: On 4/12/2019 11:08 PM, Stephen Hemminger wro

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-16 Thread Bruce Richardson
On Tue, Apr 16, 2019 at 08:03:36AM -0700, Stephen Hemminger wrote: > On Tue, 16 Apr 2019 10:42:13 +0100 > Bruce Richardson wrote: > > > On Tue, Apr 16, 2019 at 10:37:07AM +0100, Ferruh Yigit wrote: > > > On 4/12/2019 11:08 PM, Stephen Hemminger wrote: > > > > On Fri, 12 Apr 2019 17:28:17 +0100

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-16 Thread Stephen Hemminger
On Tue, 16 Apr 2019 10:42:13 +0100 Bruce Richardson wrote: > On Tue, Apr 16, 2019 at 10:37:07AM +0100, Ferruh Yigit wrote: > > On 4/12/2019 11:08 PM, Stephen Hemminger wrote: > > > On Fri, 12 Apr 2019 17:28:17 +0100 > > > Ferruh Yigit wrote: > > > > > >> On 4/8/2019 5:41 PM, Stephen Hemming

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-16 Thread Bruce Richardson
On Tue, Apr 16, 2019 at 10:37:07AM +0100, Ferruh Yigit wrote: > On 4/12/2019 11:08 PM, Stephen Hemminger wrote: > > On Fri, 12 Apr 2019 17:28:17 +0100 > > Ferruh Yigit wrote: > > > >> On 4/8/2019 5:41 PM, Stephen Hemminger wrote: > >>> If the af_packet transmit is sending a VLAN packet, > >>> and

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-16 Thread Ferruh Yigit
On 4/12/2019 11:08 PM, Stephen Hemminger wrote: > On Fri, 12 Apr 2019 17:28:17 +0100 > Ferruh Yigit wrote: > >> On 4/8/2019 5:41 PM, Stephen Hemminger wrote: >>> If the af_packet transmit is sending a VLAN packet, >>> and the transmit path to the kernel os full, then it would >>> mismanage the ou

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-12 Thread Stephen Hemminger
On Fri, 12 Apr 2019 17:28:17 +0100 Ferruh Yigit wrote: > On 4/8/2019 5:41 PM, Stephen Hemminger wrote: > > If the af_packet transmit is sending a VLAN packet, > > and the transmit path to the kernel os full, then it would > > mismanage the outgoing mbuf. The original mbuf would end up > > being f

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-12 Thread Ferruh Yigit
On 4/8/2019 5:41 PM, Stephen Hemminger wrote: > If the af_packet transmit is sending a VLAN packet, > and the transmit path to the kernel os full, then it would > mismanage the outgoing mbuf. The original mbuf would end up > being freed twice, once by AF_PACKET PMD and once by caller. This comment

[dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-08 Thread Stephen Hemminger
If the af_packet transmit is sending a VLAN packet, and the transmit path to the kernel os full, then it would mismanage the outgoing mbuf. The original mbuf would end up being freed twice, once by AF_PACKET PMD and once by caller. Reported-by: Chas Williams <3ch...@gmail.com> Signed-off-by: Steph