[dpdk-dev] [PATCH v2] mk: fix FreeBSD build

2016-07-19 Thread Christian Ehrhardt
Hi, I haven't tested the new suggested way, just went into explaining what formerly were the reasons. But I'd strongly vote against reordering and dropping comments. Sergio - v3 had still awk for some parts. It doesn't have the "0,..." you mentioned. Could you check if that is already using GNU-se

[dpdk-dev] [PATCH v2] mk: fix FreeBSD build

2016-07-19 Thread Sergio Gonzalez Monroy
Sorry Christian, I did miss your previous patches. On 19/07/2016 12:01, Christian Ehrhardt wrote: > Hi, > I haven't tested the new suggested way, just went into explaining what > formerly were the reasons. > But I'd strongly vote against reordering and dropping comments. > Fair enough. We would

[dpdk-dev] [PATCH v2] mk: fix FreeBSD build

2016-07-19 Thread Ferruh Yigit
On 7/18/2016 5:06 PM, Sergio Gonzalez Monroy wrote: > The sed syntax of '0,/regexp/' is GNU specific and fails with > non GNU sed in FreeBSD. > > To solve the issue we can use awk instead to remove duplicates. > > Fixes: b2063f104db7 ("mk: filter duplicate configuration entries") > > Signed-off-

[dpdk-dev] [PATCH v2] mk: fix FreeBSD build

2016-07-18 Thread Sergio Gonzalez Monroy
The sed syntax of '0,/regexp/' is GNU specific and fails with non GNU sed in FreeBSD. To solve the issue we can use awk instead to remove duplicates. Fixes: b2063f104db7 ("mk: filter duplicate configuration entries") Signed-off-by: Sergio Gonzalez Monroy --- v2: - Use temp var instead of temp