Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-20 Thread Bruce Richardson
On Wed, Jan 20, 2021 at 01:13:46PM +0100, Thomas Monjalon wrote: > 20/01/2021 12:54, Bruce Richardson: > > On Wed, Jan 20, 2021 at 12:09:19PM +0100, Thomas Monjalon wrote: > > > 20/01/2021 11:37, Bruce Richardson: > > > > On Tue, Jan 19, 2021 at 10:52:03PM +0100, Thomas Monjalon wrote: > > > > > 19

Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-20 Thread Thomas Monjalon
20/01/2021 12:54, Bruce Richardson: > On Wed, Jan 20, 2021 at 12:09:19PM +0100, Thomas Monjalon wrote: > > 20/01/2021 11:37, Bruce Richardson: > > > On Tue, Jan 19, 2021 at 10:52:03PM +0100, Thomas Monjalon wrote: > > > > 19/01/2021 22:31, Tyler Retzlaff: > > > > > On Sun, Jan 17, 2021 at 11:19:55P

Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-20 Thread Bruce Richardson
On Wed, Jan 20, 2021 at 12:09:19PM +0100, Thomas Monjalon wrote: > 20/01/2021 11:37, Bruce Richardson: > > On Tue, Jan 19, 2021 at 10:52:03PM +0100, Thomas Monjalon wrote: > > > 19/01/2021 22:31, Tyler Retzlaff: > > > > On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote: > > > > > > >

Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-20 Thread Thomas Monjalon
20/01/2021 11:37, Bruce Richardson: > On Tue, Jan 19, 2021 at 10:52:03PM +0100, Thomas Monjalon wrote: > > 19/01/2021 22:31, Tyler Retzlaff: > > > On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote: > > > > > > > > Not sure it makes sense without the new telemetry feature. > > > > Ple

Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-20 Thread Bruce Richardson
On Tue, Jan 19, 2021 at 10:52:03PM +0100, Thomas Monjalon wrote: > 19/01/2021 22:31, Tyler Retzlaff: > > On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote: > > > > > > Not sure it makes sense without the new telemetry feature. > > > Please focus on telemetry lib instead of half-enabl

Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-19 Thread Thomas Monjalon
19/01/2021 22:31, Tyler Retzlaff: > On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote: > > > > Not sure it makes sense without the new telemetry feature. > > Please focus on telemetry lib instead of half-enabling > > the old metrics lib. > > > > can you elaborate? (or reference a m

Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-19 Thread Tyler Retzlaff
On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote: > > Not sure it makes sense without the new telemetry feature. > Please focus on telemetry lib instead of half-enabling > the old metrics lib. > can you elaborate? (or reference a mailing list discussion) that gives some guidance?

Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-17 Thread Thomas Monjalon
12/01/2021 02:30, Tyler Retzlaff: > From: Tyler Retzlaff > > declare reduced set of exports for rte_metrics on windows and include > it in the set of libraries to build and install. > > rte_metrics_tel* exports depend on conditionally available component. > this change minimally allows enabling

[dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-11 Thread Tyler Retzlaff
From: Tyler Retzlaff declare reduced set of exports for rte_metrics on windows and include it in the set of libraries to build and install. rte_metrics_tel* exports depend on conditionally available component. this change minimally allows enabling the building of rte_metrics on windows. Signed-