Re: [dpdk-dev] [PATCH v2] mempool/octeontx2: fix possible ABI break with force inline

2019-07-18 Thread Thomas Monjalon
> > From: Pavan Nikhilesh > > > > Since direct register access is used in npa_lf_aura_op_alloc_bulk() use > > __rte_noinline instead of __rte_always_inline to preserve ABI. > > Based on the compiler npa_lf_aura_op_alloc_bulk might be inlined > > differently which may lead to undefined behaviour d

Re: [dpdk-dev] [PATCH v2] mempool/octeontx2: fix possible ABI break with force inline

2019-07-18 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, July 18, 2019 12:21 PM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev][PATCH

[dpdk-dev] [PATCH v2] mempool/octeontx2: fix possible ABI break with force inline

2019-07-17 Thread pbhagavatula
From: Pavan Nikhilesh Since direct register access is used in npa_lf_aura_op_alloc_bulk() use __rte_noinline instead of __rte_always_inline to preserve ABI. Based on the compiler npa_lf_aura_op_alloc_bulk might be inlined differently which may lead to undefined behaviour due to handcoded asm. Fi