Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Burakov, Anatoly
On 17-Apr-18 12:47 PM, Thomas Monjalon wrote: I see no reason to accept this patch, replacing strdup by snprintf, given that we have strlcpy. Please do a v3 with strlcpy. OK. Please also fix the typo in patch headline :) -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Thomas Monjalon
I see no reason to accept this patch, replacing strdup by snprintf, given that we have strlcpy. Please do a v3 with strlcpy. 17/04/2018 13:16, zhouyangchao: > As Burakov said, for no other reason, I just followed the old version. > > On Tue, Apr 17, 2018 at 6:31 PM Burakov, Anatoly > wrote: > >

Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread zhouyangchao
As Burakov said, for no other reason, I just followed the old version. On Tue, Apr 17, 2018 at 6:31 PM Burakov, Anatoly wrote: > On 17-Apr-18 11:24 AM, Thomas Monjalon wrote: > > 17/04/2018 12:06, Yangchao Zhou: > >> Coverity issue: 272585 > >> Fixes: cb97d93e9d3b ("mem: share hugepage info prim

Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Burakov, Anatoly
On 17-Apr-18 11:24 AM, Thomas Monjalon wrote: 17/04/2018 12:06, Yangchao Zhou: Coverity issue: 272585 Fixes: cb97d93e9d3b ("mem: share hugepage info primary and secondary") Signed-off-by: Yangchao Zhou Acked-by: Anatoly Burakov Better to provide a small explanation. -

Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Thomas Monjalon
17/04/2018 12:06, Yangchao Zhou: > Coverity issue: 272585 > Fixes: cb97d93e9d3b ("mem: share hugepage info primary and secondary") > > Signed-off-by: Yangchao Zhou > Acked-by: Anatoly Burakov Better to provide a small explanation. > - retval = strdup(splitst

[dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Yangchao Zhou
Coverity issue: 272585 Fixes: cb97d93e9d3b ("mem: share hugepage info primary and secondary") Signed-off-by: Yangchao Zhou Acked-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/