Re: [dpdk-dev] [PATCH v2] mem: improve parameter checking on memory hotplug

2021-01-21 Thread Burakov, Anatoly
On 19-Jan-21 11:39 PM, Thomas Monjalon wrote: 18/01/2021 16:41, Anatoly Burakov: + /* now that we've validated the request, time for a PSA */ What is PSA? Public Service Announcement :) + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE, + m->free_req.ad

Re: [dpdk-dev] [PATCH v2] mem: improve parameter checking on memory hotplug

2021-01-19 Thread Thomas Monjalon
18/01/2021 16:41, Anatoly Burakov: > + /* now that we've validated the request, time for a PSA */ What is PSA? > + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE, > + m->free_req.addr, m->free_req.len); [...] > + /* this is checked by the API, but we need to pre

[dpdk-dev] [PATCH v2] mem: improve parameter checking on memory hotplug

2021-01-18 Thread Anatoly Burakov
Currently, we don't check anything that comes in through memory hotplug subsystem using the IPC, because we always assume the data is correct. This is okay as anyone having access to the IPC socket would also have rights to crash the DPDK process through other means, but it's still a good practice