[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-13 Thread Bruce Richardson
nesday, January 13, 2016 1:48 PM > To: Hanoch Haim (hhaim) > Cc: Olivier MATZ; dev at dpdk.org; Ido Barnea (ibarnea); Itay Marom (imarom) > Subject: Re: [dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update > > On Tue, Jan 05, 2016 at 11:11:24AM +, Hanoch Haim (hhaim) wrote:

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-13 Thread Hanoch Haim (hhaim)
, 2016 1:48 PM To: Hanoch Haim (hhaim) Cc: Olivier MATZ; dev at dpdk.org; Ido Barnea (ibarnea); Itay Marom (imarom) Subject: Re: [dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update On Tue, Jan 05, 2016 at 11:11:24AM +, Hanoch Haim (hhaim) wrote: > Hi Oliver, > Thank you for th

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-13 Thread Bruce Richardson
On Tue, Jan 05, 2016 at 11:11:24AM +, Hanoch Haim (hhaim) wrote: > Hi Oliver, > Thank you for the fast response and it would be great to open a discussion on > that. > In general our project can leverage your optimization and I think it is great > (we should have thought about it) . We can u

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-05 Thread Olivier MATZ
Hi Hanoch, On 01/05/2016 12:11 PM, Hanoch Haim (hhaim) wrote: > Hi Oliver, > Thank you for the fast response and it would be great to open a discussion on > that. > In general our project can leverage your optimization and I think it is great > (we should have thought about it) . We can use it u

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-05 Thread Olivier MATZ
Hi Hanoch, On 01/04/2016 03:43 PM, Hanoch Haim (hhaim) wrote: > Hi Oliver, > > Let's take your drawing as a reference and add my question > The use case is sending a duplicate multicast packet by many threads. > I can split it to x threads to do the job and with atomic-ref (my multicast > not mbu

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-05 Thread Hanoch Haim (hhaim)
tel.com Cc: dev at dpdk.org; Ido Barnea (ibarnea); Itay Marom (imarom) Subject: Re: [dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update Hi Hanoch, On 01/04/2016 03:43 PM, Hanoch Haim (hhaim) wrote: > Hi Oliver, > > Let's take your drawing as a reference and add my question

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-04 Thread Olivier MATZ
Hi Hanoch, Please find some comments below. On 12/27/2015 10:39 AM, Hanoch Haim (hhaim) wrote: > Hi Bruce, > > I'm Hanoch from Cisco Systems works for the > https://github.com/cisco-system-traffic-generator/trex-core traffic generator > project. > > While upgrading from DPDK 1.8 to 2.2 Ido f

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2016-01-04 Thread Hanoch Haim (hhaim)
Ido Barnea (ibarnea); Itay Marom (imarom) Subject: Re: [dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update Hi Hanoch, Please find some comments below. On 12/27/2015 10:39 AM, Hanoch Haim (hhaim) wrote: > Hi Bruce, > > I'm Hanoch from Cisco Systems works for the > htt

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2015-12-27 Thread Hanoch Haim (hhaim)
Hi Bruce, I'm Hanoch from Cisco Systems works for the https://github.com/cisco-system-traffic-generator/trex-core traffic generator project. While upgrading from DPDK 1.8 to 2.2 Ido found that the following commit creates a mbuf corruption and result in Tx hang commit f20b50b946da9070d21e3

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2015-06-12 Thread Thomas Monjalon
2015-06-09 13:57, Bruce Richardson: > On Mon, Jun 08, 2015 at 04:57:22PM +0200, Olivier Matz wrote: > > In __rte_pktmbuf_prefree_seg(), there was an optimization to avoid using > > a costly atomic operation when updating the mbuf reference counter if > > its value is 1. Indeed, it means that we are

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2015-06-09 Thread Bruce Richardson
On Mon, Jun 08, 2015 at 04:57:22PM +0200, Olivier Matz wrote: > In __rte_pktmbuf_prefree_seg(), there was an optimization to avoid using > a costly atomic operation when updating the mbuf reference counter if > its value is 1. Indeed, it means that we are the only owner of the mbuf, > and therefore

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2015-06-08 Thread Olivier Matz
In __rte_pktmbuf_prefree_seg(), there was an optimization to avoid using a costly atomic operation when updating the mbuf reference counter if its value is 1. Indeed, it means that we are the only owner of the mbuf, and therefore nobody can change it at the same time. We can generalize this optimi