Re: [dpdk-dev] [PATCH v2] mbuf: move headers not fragmented check to checksum

2019-04-02 Thread Thomas Monjalon
29/03/2019 15:18, Olivier Matz: > On Fri, Mar 29, 2019 at 01:42:14PM +, Andrew Rybchenko wrote: > > rte_validate_tx_offload() is used in Tx prepare callbacks > > (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. > > Requirement that packet headers should not be fragmented is not

Re: [dpdk-dev] [PATCH v2] mbuf: move headers not fragmented check to checksum

2019-03-29 Thread Olivier Matz
On Fri, Mar 29, 2019 at 01:42:14PM +, Andrew Rybchenko wrote: > rte_validate_tx_offload() is used in Tx prepare callbacks > (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. > Requirement that packet headers should not be fragmented is not > documented and unclear where it comes

[dpdk-dev] [PATCH v2] mbuf: move headers not fragmented check to checksum

2019-03-29 Thread Andrew Rybchenko
rte_validate_tx_offload() is used in Tx prepare callbacks (RTE_LIBRTE_ETHDEV_DEBUG only) to check Tx offloads consistency. Requirement that packet headers should not be fragmented is not documented and unclear where it comes from except rte_net_intel_cksum_prepare() functions which relies on it. I