Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-21 Thread David Marchand
On Thu, Jul 16, 2020 at 5:49 PM Ruifeng Wang wrote: > > Coverity complains about unchecked return value of rte_rcu_qsbr_dq_enqueue. > By default, defer queue size is big enough to hold all tbl8 groups. When > enqueue fails, return error to the user to indicate system issue. > > Coverity issue: 360

Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-21 Thread David Marchand
On Tue, Jul 21, 2020 at 7:16 PM Bruce Richardson wrote: > > On Tue, Jul 21, 2020 at 05:23:02PM +0100, Medvedkin, Vladimir wrote: > > Hi Ruifeng, > > > > On 18/07/2020 10:22, Ruifeng Wang wrote: > > > > > > > -Original Message- > > > > From: Medvedkin, Vladimir > > > > Sent: Saturday, July

Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-21 Thread Bruce Richardson
On Tue, Jul 21, 2020 at 05:23:02PM +0100, Medvedkin, Vladimir wrote: > Hi Ruifeng, > > On 18/07/2020 10:22, Ruifeng Wang wrote: > > > > > -Original Message- > > > From: Medvedkin, Vladimir > > > Sent: Saturday, July 18, 2020 1:12 AM > > > To: Ruifeng Wang ; Bruce Richardson > > > > > >

Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-21 Thread Medvedkin, Vladimir
Hi Ruifeng, On 18/07/2020 10:22, Ruifeng Wang wrote: -Original Message- From: Medvedkin, Vladimir Sent: Saturday, July 18, 2020 1:12 AM To: Ruifeng Wang ; Bruce Richardson Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli ; Phil Yang Subject: Re: [PATCH v2] lpm: fix unchecked return value

Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-18 Thread Ruifeng Wang
> -Original Message- > From: Medvedkin, Vladimir > Sent: Saturday, July 18, 2020 1:12 AM > To: Ruifeng Wang ; Bruce Richardson > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Phil Yang > Subject: Re: [PATCH v2] lpm: fix unchecked return value > > Hi Ruifeng, > Hi Vladimir, > On 1

Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-17 Thread Medvedkin, Vladimir
Hi Ruifeng, On 16/07/2020 16:49, Ruifeng Wang wrote: Coverity complains about unchecked return value of rte_rcu_qsbr_dq_enqueue. By default, defer queue size is big enough to hold all tbl8 groups. When enqueue fails, return error to the user to indicate system issue. Coverity issue: 360832 Fixe

[dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-16 Thread Ruifeng Wang
Coverity complains about unchecked return value of rte_rcu_qsbr_dq_enqueue. By default, defer queue size is big enough to hold all tbl8 groups. When enqueue fails, return error to the user to indicate system issue. Coverity issue: 360832 Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")