Re: [dpdk-dev] [PATCH v2] lib/rte_rib6: fix stack buffer overflow

2021-06-18 Thread Medvedkin, Vladimir
On 18/06/2021 19:22, Medvedkin, Vladimir wrote: Hi Owen, Just a few nits inlined below On 16/06/2021 21:18, ohily...@iol.unh.edu wrote: From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was alw

Re: [dpdk-dev] [PATCH v2] lib/rte_rib6: fix stack buffer overflow

2021-06-18 Thread Medvedkin, Vladimir
Hi Owen, Just a few nits inlined below On 16/06/2021 21:18, ohily...@iol.unh.edu wrote: From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the inde

[dpdk-dev] [PATCH v2] lib/rte_rib6: fix stack buffer overflow

2021-06-16 Thread ohilyard
From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the ip address to be 16, which read off the end of the array. While trying to solve