Re: [dpdk-dev] [PATCH v2] hash: fix tuple adjustment

2021-05-05 Thread Stanislaw Kardach
On Tue, May 04, 2021 at 03:25:04PM +0100, Vladimir Medvedkin wrote: > rte_thash_adjust_tuple() uses random to generate a new subtuple if > fn() callback reports about collision. In some cases random changes > the subtuple in a way that after complementary bits are applied the > original tuple is ob

Re: [dpdk-dev] [PATCH v2] hash: fix tuple adjustment

2021-05-05 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, May 4, 2021 7:25 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Chilikin, Andrey > ; Kinsella, Ray ; Wang, > Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > ; david.march...@redhat.com; > k...@semihalf.com; Medvedkin, Vl

Re: [dpdk-dev] [PATCH v2] hash: fix tuple adjustment

2021-05-05 Thread Thomas Monjalon
04/05/2021 16:25, Vladimir Medvedkin: > rte_thash_adjust_tuple() uses random to generate a new subtuple if > fn() callback reports about collision. In some cases random changes > the subtuple in a way that after complementary bits are applied the > original tuple is obtained. This patch replaces ra

[dpdk-dev] [PATCH v2] hash: fix tuple adjustment

2021-05-04 Thread Vladimir Medvedkin
rte_thash_adjust_tuple() uses random to generate a new subtuple if fn() callback reports about collision. In some cases random changes the subtuple in a way that after complementary bits are applied the original tuple is obtained. This patch replaces random with subtuple increment. Fixes: 28ebff11