Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-15 Thread Hu, Jiayu
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, January 15, 2019 6:12 PM > To: Wang, Yinan ; Hu, Jiayu ; > dev@dpdk.org > Cc: tho...@monjalon.net; Hu, Jiayu ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] gro: add missi

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-15 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, January 15, 2019 6:12 PM > To: Wang, Yinan ; Hu, Jiayu ; > dev@dpdk.org > Cc: tho...@monjalon.net; Hu, Jiayu ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] gro: add missing inval

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-15 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: Wang, Yinan > Sent: Tuesday, January 15, 2019 5:05 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; tho...@monjalon.net; > Hu, Jiayu ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] gro: add missing invalid packet

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-14 Thread Wang, Yinan
Tested-by: Yinan Wang Best Wishes, Yinan -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu Sent: 2019年1月10日 23:06 To: dev@dpdk.org Cc: Ananyev, Konstantin ; tho...@monjalon.net; Hu, Jiayu ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v2] gro: add missing

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-14 Thread Hu, Jiayu
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, January 15, 2019 9:00 AM > To: Hu, Jiayu > Cc: dev@dpdk.org; Ananyev, Konstantin ; > tho...@monjalon.net; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] gro

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-14 Thread Stephen Hemminger
On Thu, 10 Jan 2019 23:06:08 +0800 Jiayu Hu wrote: > + > +#define ILLEGAL_ETHER_HDRLEN(len) ((len) != ETHER_HDR_LEN) > +#define ILLEGAL_ETHER_VXLAN_HDRLEN(len) \ > + ((len) != (ETHER_VXLAN_HLEN + ETHER_HDR_LEN)) > +#define ILLEGAL_IPV4_HDRLEN(len) ((len) != sizeof(struct ipv4_hdr)) > +#define

[dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

2019-01-10 Thread Jiayu Hu
Currently, GRO library doesn't check if input packets have invalid headers. The packets with invalid headers will also be processed by GRO. However, GRO shouldn't process invalid packets. This patch adds missing invalid packet checks. Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4") Fixes: 9e0b9