Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-14 Thread Thomas Monjalon
13/01/2019 16:38, Nithin Kumar Dabilpuram: > Currently this api doesn't report error if name is > truncated and so user is not sure about uniqueness > of name. This change reports error to help user. > > Signed-off-by: Nithin Dabilpuram > --- > + if (rc >= RTE_MEMZONE_NAMESIZE) { > +

Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-13 Thread Andrew Rybchenko
On 1/14/19 12:21 AM, Thomas Monjalon wrote: 13/01/2019 21:19, Wiles, Keith: On Jan 13, 2019, at 2:02 PM, Thomas Monjalon wrote: 13/01/2019 20:28, Wiles, Keith: On Jan 13, 2019, at 9:38 AM, Nithin Kumar Dabilpuram wrote: --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.

Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-13 Thread Thomas Monjalon
13/01/2019 21:19, Wiles, Keith: > > On Jan 13, 2019, at 2:02 PM, Thomas Monjalon wrote: > > 13/01/2019 20:28, Wiles, Keith: > >>> On Jan 13, 2019, at 9:38 AM, Nithin Kumar Dabilpuram > >>> wrote: > >>> --- a/lib/librte_ethdev/rte_ethdev.c > >>> +++ b/lib/librte_ethdev/rte_ethdev.c > >>> + if (rc

Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-13 Thread Wiles, Keith
> On Jan 13, 2019, at 2:02 PM, Thomas Monjalon wrote: > > 13/01/2019 20:28, Wiles, Keith: >>> On Jan 13, 2019, at 9:38 AM, Nithin Kumar Dabilpuram >>> wrote: >>> --- a/lib/librte_ethdev/rte_ethdev.c >>> +++ b/lib/librte_ethdev/rte_ethdev.c >>> + if (rc >= RTE_MEMZONE_NAMESIZE) { >>> +

Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-13 Thread Thomas Monjalon
13/01/2019 20:28, Wiles, Keith: > > On Jan 13, 2019, at 9:38 AM, Nithin Kumar Dabilpuram > > wrote: > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > + if (rc >= RTE_MEMZONE_NAMESIZE) { > > + RTE_ETHDEV_LOG(ERR, "truncated name"); > > + rt

Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-13 Thread Wiles, Keith
> On Jan 13, 2019, at 9:38 AM, Nithin Kumar Dabilpuram > wrote: > > Currently this api doesn't report error if name is > truncated and so user is not sure about uniqueness > of name. This change reports error to help user. > > Signed-off-by: Nithin Dabilpuram > --- > > v2: > Fix issue caus

[dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-13 Thread Nithin Kumar Dabilpuram
Currently this api doesn't report error if name is truncated and so user is not sure about uniqueness of name. This change reports error to help user. Signed-off-by: Nithin Dabilpuram --- v2: Fix issue caused by rebase and also fix log message lib/librte_ethdev/rte_ethdev.c | 11 +-- 1