Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-06 Thread Thomas Monjalon
05/11/2021 22:33, Ferruh Yigit: > On 11/5/2021 4:26 PM, Stephen Hemminger wrote: > > On Fri, 05 Nov 2021 16:05:14 +0100 > > Thomas Monjalon wrote: > > > > > > What do you think about marking old macros as deprecated? > > > > This will cause warning in application code that is usin

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-05 Thread Ferruh Yigit
On 11/5/2021 4:26 PM, Stephen Hemminger wrote: On Fri, 05 Nov 2021 16:05:14 +0100 Thomas Monjalon wrote: What do you think about marking old macros as deprecated? This will cause warning in application code that is using old macros, but shouldn't fail their build (unless -Werror is issued).

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-05 Thread Stephen Hemminger
On Fri, 05 Nov 2021 16:05:14 +0100 Thomas Monjalon wrote: > > >> > > >> What do you think about marking old macros as deprecated? > > >> > > >> This will cause warning in application code that is using > > >> old macros, but shouldn't fail their build (unless -Werror > > >> is issued). > > > >

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-05 Thread Thomas Monjalon
05/11/2021 14:40, Andrew Rybchenko: > On 11/4/21 3:59 PM, Thomas Monjalon wrote: > > 04/11/2021 12:03, Ferruh Yigit: > >> On 11/3/2021 10:48 PM, Ferruh Yigit wrote: > >>> Old macros kept for backward compatibility, but this cause old macro > >>> usage to sneak in silently. > >>> > >>> Marking old m

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-05 Thread Andrew Rybchenko
On 11/4/21 3:59 PM, Thomas Monjalon wrote: > 04/11/2021 12:03, Ferruh Yigit: >> On 11/3/2021 10:48 PM, Ferruh Yigit wrote: >>> Old macros kept for backward compatibility, but this cause old macro >>> usage to sneak in silently. >>> >>> Marking old macros as deprecated. Downside is this will cause s

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-04 Thread Thomas Monjalon
04/11/2021 12:03, Ferruh Yigit: > On 11/3/2021 10:48 PM, Ferruh Yigit wrote: > > Old macros kept for backward compatibility, but this cause old macro > > usage to sneak in silently. > > > > Marking old macros as deprecated. Downside is this will cause some noise > > for applications that are using

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-04 Thread Ferruh Yigit
On 11/3/2021 10:48 PM, Ferruh Yigit wrote: Old macros kept for backward compatibility, but this cause old macro usage to sneak in silently. Marking old macros as deprecated. Downside is this will cause some noise for applications that are using old macros. Fixes: 295968d17407 ("ethdev: add name

[dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-03 Thread Ferruh Yigit
Old macros kept for backward compatibility, but this cause old macro usage to sneak in silently. Marking old macros as deprecated. Downside is this will cause some noise for applications that are using old macros. Fixes: 295968d17407 ("ethdev: add namespace") Signed-off-by: Ferruh Yigit Acked-b