Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-19 Thread Ferruh Yigit
On 9/19/2018 8:34 AM, David Marchand wrote: > Hello Ferruh, > > On Fri, Sep 14, 2018 at 1:37 PM, Ferruh Yigit wrote: >> On 9/4/2018 11:02 AM, Shahaf Shuler wrote: >>> Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-19 Thread David Marchand
Hello Ferruh, On Fri, Sep 14, 2018 at 1:37 PM, Ferruh Yigit wrote: > On 9/4/2018 11:02 AM, Shahaf Shuler wrote: >> Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: >>> Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx >>> >>> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. >>> Wit

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-18 Thread Legacy, Allain
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, September 10, 2018 7:35 AM > To: Ferruh Yigit > Cc: Wenzhuo Lu; Jingjing Wu; Bernard Iremonger; John McNamara; Marko > Kovacevic; Qi Zhang; Xiao Wang; Neil Horman; Remy Horton; Ori Kam; Bruce

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-14 Thread Ferruh Yigit
On 9/4/2018 11:02 AM, Shahaf Shuler wrote: > Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: >> Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx >> >> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. >> Without any specific Rx offload flag, default behavior by PMDs is to >> strip C

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-11 Thread Hyong Youb Kim
On Tue, Sep 04, 2018 at 11:12:56AM +0100, Ferruh Yigit wrote: > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. >

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-10 Thread Jerin Jacob
-Original Message- > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. > > Applications that require keep

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-10 Thread Jan Remeš
For szedata2: Acked-by: Jan Remes Thanks, Jan > --- a/drivers/net/szedata2/rte_eth_szedata2.c > +++ b/drivers/net/szedata2/rte_eth_szedata2.c > @@ -1056,8 +1056,7 @@ eth_dev_info(struct rte_eth_dev *dev, > dev_info->max_rx_queues = internals->max_rx_queues; > dev_info->max_tx_qu

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-10 Thread Maxime Coquelin
On 09/04/2018 12:12 PM, Ferruh Yigit wrote: diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index e58f32211..aa6052221 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -1070,8 +1070,7 @@ eth_dev_info(struct rte_eth_de

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-04 Thread Shahaf Shuler
Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: > Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should adv

[dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

2018-09-04 Thread Ferruh Yigit
Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. Without any specific Rx offload flag, default behavior by PMDs is to strip CRC. PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC Rx offload capability. Applications that require keeping CRC should check PMD capability first and