Re: [dpdk-dev] [PATCH v2] ethdev: extend flow metadata

2019-10-24 Thread Slava Ovsiienko
Hi Olivier, > -Original Message- > From: Olivier Matz > Sent: Thursday, October 24, 2019 12:23 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan > Darawsheh ; Thomas Monjalon > > Subject: Re: [PATCH v2] ethdev: extend flow metadata > > Hi Slava, > > On Thu, Oct 24, 2019 at 0

Re: [dpdk-dev] [PATCH v2] ethdev: extend flow metadata

2019-10-24 Thread Olivier Matz
Hi Slava, On Thu, Oct 24, 2019 at 06:49:41AM +, Slava Ovsiienko wrote: > Hi, Olivier > > > > [snip] > > > > > > > > +int > > > > > +rte_flow_dynf_metadata_register(void) > > > > > +{ > > > > > + int offset; > > > > > + int flag; > > > > > + > > > > > + static const struct rte_mbuf

Re: [dpdk-dev] [PATCH v2] ethdev: extend flow metadata

2019-10-23 Thread Slava Ovsiienko
Hi, Olivier > > [snip] > > > > > > +int > > > > +rte_flow_dynf_metadata_register(void) > > > > +{ > > > > + int offset; > > > > + int flag; > > > > + > > > > + static const struct rte_mbuf_dynfield desc_offs = { > > > > + .name = MBUF_DYNF_METADATA_NAME, > > > > +

Re: [dpdk-dev] [PATCH v2] ethdev: extend flow metadata

2019-10-21 Thread Olivier Matz
Hi Slava, On Sat, Oct 19, 2019 at 07:47:59PM +, Slava Ovsiienko wrote: > Hi, Olivier > > Thank you for your comment (and for the dynamic mbuf patch, btw). Please, see > below. > > > -Original Message- > > From: Olivier Matz > > Sent: Friday, October 18, 2019 12:22 > > To: Slava Ovs

Re: [dpdk-dev] [PATCH v2] ethdev: extend flow metadata

2019-10-19 Thread Slava Ovsiienko
Hi, Olivier Thank you for your comment (and for the dynamic mbuf patch, btw). Please, see below. > -Original Message- > From: Olivier Matz > Sent: Friday, October 18, 2019 12:22 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan > Darawsheh ; Thomas Monjalon > ; Yongseok Ko

Re: [dpdk-dev] [PATCH v2] ethdev: extend flow metadata

2019-10-18 Thread Olivier Matz
Hi Viacheslav, Few comments on the dynamic mbuf part below. On Thu, Oct 10, 2019 at 04:02:39PM +, Viacheslav Ovsiienko wrote: > Currently, metadata can be set on egress path via mbuf tx_metadata field > with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. > > This patch ex

[dpdk-dev] [PATCH v2] ethdev: extend flow metadata

2019-10-10 Thread Viacheslav Ovsiienko
Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. This patch extends the metadata feature usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx metadata can also be set by a r