Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Thomas Monjalon
10/10/2018 20:01, Andrew Rybchenko: > On 10.10.2018 19:43, Thomas Monjalon wrote: > > 10/10/2018 17:01, Andrew Rybchenko: > >> On 10/10/18 11:39 AM, Thomas Monjalon wrote: > >>> 10/10/2018 09:50, Andrew Rybchenko: > On 10/10/18 10:44 AM, Thomas Monjalon wrote: > > 10/10/2018 08:15, Andrew

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Andrew Rybchenko
On 10.10.2018 19:43, Thomas Monjalon wrote: 10/10/2018 17:01, Andrew Rybchenko: On 10/10/18 11:39 AM, Thomas Monjalon wrote: 10/10/2018 09:50, Andrew Rybchenko: On 10/10/18 10:44 AM, Thomas Monjalon wrote: 10/10/2018 08:15, Andrew Rybchenko: On 10/10/18 1:17 AM, Thomas Monjalon wrote: After

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Thomas Monjalon
10/10/2018 17:01, Andrew Rybchenko: > On 10/10/18 11:39 AM, Thomas Monjalon wrote: > > 10/10/2018 09:50, Andrew Rybchenko: > >> On 10/10/18 10:44 AM, Thomas Monjalon wrote: > >>> 10/10/2018 08:15, Andrew Rybchenko: > On 10/10/18 1:17 AM, Thomas Monjalon wrote: > > After closing a port, it

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Andrew Rybchenko
On 10/10/18 11:39 AM, Thomas Monjalon wrote: 10/10/2018 09:50, Andrew Rybchenko: On 10/10/18 10:44 AM, Thomas Monjalon wrote: 10/10/2018 08:15, Andrew Rybchenko: On 10/10/18 1:17 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all ass

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Thomas Monjalon
10/10/2018 09:50, Andrew Rybchenko: > On 10/10/18 10:44 AM, Thomas Monjalon wrote: > > 10/10/2018 08:15, Andrew Rybchenko: > >> On 10/10/18 1:17 AM, Thomas Monjalon wrote: > >>> After closing a port, it cannot be restarted. > >>> So there is no reason to not free all associated resources. > >>> > >

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Andrew Rybchenko
On 10/10/18 10:44 AM, Thomas Monjalon wrote: 10/10/2018 08:15, Andrew Rybchenko: On 10/10/18 1:17 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is depre

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Thomas Monjalon
10/10/2018 08:15, Andrew Rybchenko: > On 10/10/18 1:17 AM, Thomas Monjalon wrote: > > After closing a port, it cannot be restarted. > > So there is no reason to not free all associated resources. > > > > The last step was done with rte_eth_dev_detach() which is deprecated. > > Instead of blindly re

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-09 Thread Andrew Rybchenko
On 10/10/18 1:17 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should che

[dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-09 Thread Thomas Monjalon
After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should check if no more port (ethdev, cryptodev, etc) is