Re: [dpdk-dev] [PATCH v2] ethdev: change queue release callback

2021-09-17 Thread Xueming(Steven) Li
On Thu, 2021-09-16 at 17:50 +0200, Thomas Monjalon wrote: > 16/09/2021 17:43, Xueming(Steven) Li: > > On Thu, 2021-09-16 at 10:09 +0200, Thomas Monjalon wrote: > > > 15/09/2021 15:02, Xueming Li: > > > > --- a/lib/ethdev/rte_ethdev.c > > > > +++ b/lib/ethdev/rte_ethdev.c > > > > - >

Re: [dpdk-dev] [PATCH v2] ethdev: change queue release callback

2021-09-16 Thread Thomas Monjalon
16/09/2021 17:43, Xueming(Steven) Li: > On Thu, 2021-09-16 at 10:09 +0200, Thomas Monjalon wrote: > > 15/09/2021 15:02, Xueming Li: > > > --- a/lib/ethdev/rte_ethdev.c > > > +++ b/lib/ethdev/rte_ethdev.c > > > - RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, > > > -ENOTSUP); > >

Re: [dpdk-dev] [PATCH v2] ethdev: change queue release callback

2021-09-16 Thread Xueming(Steven) Li
On Thu, 2021-09-16 at 10:09 +0200, Thomas Monjalon wrote: > 15/09/2021 15:02, Xueming Li: > > To align with other eth device queue configuration callbacks, cleanup > > queue release callback API by changing RX and TX queue release callback > > API parameter from queue object to device and queue ind

Re: [dpdk-dev] [PATCH v2] ethdev: change queue release callback

2021-09-16 Thread Thomas Monjalon
15/09/2021 15:02, Xueming Li: > To align with other eth device queue configuration callbacks, cleanup > queue release callback API by changing RX and TX queue release callback > API parameter from queue object to device and queue index. Please split the explanation in multiple sentences, so it all