Re: [dpdk-dev] [PATCH v2] ethdev: allow all ports event registration

2017-12-30 Thread Matan Azrad
From: Thomas Monjalon, December 30, 2017 10:51 PM > 30/12/2017 20:04, Matan Azrad: > > From: Thomas Monjalon, December 29, 2017 > > > 04/12/2017 16:43, Matan Azrad: > > > > @@ -2827,37 +2837,59 @@ > > > > + uint32_t next_port; > > > > + uint32_t last_port; > > > > > > A port id shoul

Re: [dpdk-dev] [PATCH v2] ethdev: allow all ports event registration

2017-12-30 Thread Thomas Monjalon
30/12/2017 20:04, Matan Azrad: > From: Thomas Monjalon, December 29, 2017 > > 04/12/2017 16:43, Matan Azrad: > > > @@ -2827,37 +2837,59 @@ > > > + uint32_t next_port; > > > + uint32_t last_port; > > > > A port id should be uint16_t. > > > Yes, I know but please note that we use next_port variabl

Re: [dpdk-dev] [PATCH v2] ethdev: allow all ports event registration

2017-12-30 Thread Matan Azrad
Hi Thomas From: Thomas Monjalon, December 29, 2017 > Hi Matan, > > Please find some review details below. > > As this patch is needed for the notification of new ports, I will re-send them > in a patchset, with the minor modifications described below. > > 04/12/2017 16:43, Matan Azrad: > > --

Re: [dpdk-dev] [PATCH v2] ethdev: allow all ports event registration

2017-12-29 Thread Thomas Monjalon
Hi Matan, Please find some review details below. As this patch is needed for the notification of new ports, I will re-send them in a patchset, with the minor modifications described below. 04/12/2017 16:43, Matan Azrad: > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c

[dpdk-dev] [PATCH v2] ethdev: allow all ports event registration

2017-12-04 Thread Matan Azrad
Add option to register event callback for all ports by one call to rte_eth_dev_callback_register using port_id=RTE_ETH_ALL. In this case the callback is also registered to invalid ports. Signed-off-by: Matan Azrad --- lib/librte_ether/rte_ethdev.c | 124 +