Re: [dpdk-dev] [PATCH v2] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

2019-04-10 Thread Xu, Rosen
> -Original Message- > From: Li Qiang [mailto:liq...@163.com] > Sent: Wednesday, April 10, 2019 21:43 > To: Xu, Rosen ; Zhang, Tianfei > > Cc: dev@dpdk.org; liq...@gmail.com; Li Qiang > Subject: [PATCH v2] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr > > In rte_fpga_do_pr() fu

[dpdk-dev] [PATCH v2] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

2019-04-10 Thread Li Qiang
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this. Spotted by Coverity: CID 27441 Signed-off-by: Li Qiang --- Changes since v1: fill ret before goto close_fd per Rosen's review drivers/raw/ifpga_rawdev/ifpga_rawdev