Re: [dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides

2020-07-24 Thread Power, Ciara
Hi Thomas, Thanks for the review. I have addressed your comments in the v3 patch, with one exception mentioned below. >[...] >> + * List all commands. >> + >> + .. code-block:: console > >I think you can achieve the same result as code-block with adding double >colons (::) at the end o

Re: [dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides

2020-07-22 Thread Thomas Monjalon
21/07/2020 18:09, Ciara Power: > --- a/doc/guides/howto/telemetry.rst > +++ b/doc/guides/howto/telemetry.rst > @@ -1,6 +1,7 @@ > .. SPDX-License-Identifier: BSD-3-Clause > Copyright(c) 2020 Intel Corporation. > > +.. _telemetry: We don't need such anchor. The beginning of a page can be li

Re: [dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides

2020-07-21 Thread Bruce Richardson
On Tue, Jul 21, 2020 at 05:09:24PM +0100, Ciara Power wrote: > This patch adds examples to the Telemetry HowTo guide, to demonstrate > commands that use parameters. The programmer's guide is also modified to > include details on writing a callback function for a new command. > > Signed-off-by: Cia

[dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides

2020-07-21 Thread Ciara Power
This patch adds examples to the Telemetry HowTo guide, to demonstrate commands that use parameters. The programmer's guide is also modified to include details on writing a callback function for a new command. Signed-off-by: Ciara Power --- v2: - Replaced examples of using commands in the progr