Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-14 Thread Shally Verma
HI Fiona > -Original Message- > From: Trahe, Fiona > Sent: Tuesday, May 14, 2019 9:00 PM > To: Shally Verma ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila Sahu ; sta...@dpdk.org; > Trahe, Fiona > Subject: RE: [PATCH v2] doc/compress: clarify error handling

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-14 Thread Trahe, Fiona
Hi Shally, Although we're close to agreement on this, I'm reconsidering. I think the difficulty we've had finding the best wording highlights the confusion an app developer will have in figuring out how to handle errors on enqueue. So I'm proposing to drop this - which was intended to allow some

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-09 Thread Shally Verma
HI Fiona > -Original Message- > From: Fiona Trahe > Sent: Tuesday, April 9, 2019 8:26 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; > lee.d...@intel.com; Sunila Sahu ; Shally Verma > ; Fiona Trahe ; > sta...@dpdk.org > Subject: [PATCH v2] doc/compress: clarify error hand

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-09 Thread Akhil Goyal
Hi Fiona/Shally, Can we get a closure on this patch by today EOD(We are closing tree for RC4 today). Thomas will pick this patch directly on master. Thanks, Akhil > -Original Message- > From: Trahe, Fiona > Sent: Wednesday, May 8, 2019 7:31 PM > To: Shally Verma ; dev@dpdk.org > Cc: Ak

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-08 Thread Trahe, Fiona
HI Shally, > -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Wednesday, May 8, 2019 1:41 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila > Sahu ; sta...@dpdk.org > Subject: RE: [PATCH v2] doc/compress: clarif

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-08 Thread Shally Verma
Hi Fiona > -Original Message- > From: Trahe, Fiona > Sent: Tuesday, May 7, 2019 11:54 PM > To: Shally Verma ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila Sahu ; sta...@dpdk.org; > Trahe, Fiona > Subject: RE: [PATCH v2] doc/compress: clarify error handling

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-07 Thread Trahe, Fiona
Hi Shally > > > > + > > > > +There are some exceptions whereby errors can occur on the > > ``enqueue``. > > > > +For any error which can occur in a production environment and can > > > > +be successful after a retry with the same op the PMD may return the > > > > +error on the enqueue. > > > This

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-07 Thread Shally Verma
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, April 30, 2019 10:04 PM > To: Shally Verma ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila Sahu ; sta...@dpdk.org; > Trahe, Fiona > Subject: RE: [PATCH v2] doc/compress: clarify error handling on d

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-04-30 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Thursday, April 18, 2019 1:12 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila > Sahu ; sta...@dpdk.org > Subject: RE: [PATCH v2] doc/compress: cla

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-04-18 Thread Shally Verma
Hi Fiona, > -Original Message- > From: Fiona Trahe > Sent: Tuesday, April 9, 2019 8:26 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; > lee.d...@intel.com; Sunila Sahu ; Shally Verma > ; Fiona Trahe ; > sta...@dpdk.org > Subject: [PATCH v2] doc/compress: clarify error ha

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-04-16 Thread Akhil Goyal
Hi Shally/Ashish, Could you please review this patch. Thanks, Akhil > > Fixed some typos and clarified which errors should be returned > when and why on the enqueue and dequeue APIs. > > Fixes: a584d3bea902 ("doc: add compressdev library guide") > cc: sta...@dpdk.org > > Signed-off-by: Fiona Tr

[dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-04-09 Thread Fiona Trahe
Fixed some typos and clarified which errors should be returned when and why on the enqueue and dequeue APIs. Fixes: a584d3bea902 ("doc: add compressdev library guide") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- v2 changes: - changed "0 or undefined" to just "undefined" as 0 is superfluo