Re: [dpdk-dev] [PATCH v2] devtools: add explicit warning messages for forbidden tokens

2018-11-02 Thread Arnon Warshavsky
> > > I think I prefer passing the string directly. > You can make a shorter message: > Using explicit .svg extension in rST instead of .* > or > Using explicit .svg extension instead of .* > > > Ok

Re: [dpdk-dev] [PATCH v2] devtools: add explicit warning messages for forbidden tokens

2018-11-02 Thread Thomas Monjalon
02/11/2018 11:37, Arnon Warshavsky: > > > > > + message="Using explicit .svg extension in figures instead of .*" > > > awk -v FOLDERS='doc' \ > > > -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \ > > > -v RET_ON_FAIL=1 \ > > > + -v MESSAGE="$me

Re: [dpdk-dev] [PATCH v2] devtools: add explicit warning messages for forbidden tokens

2018-11-02 Thread Arnon Warshavsky
> > > + message="Using explicit .svg extension in figures instead of .*" > > awk -v FOLDERS='doc' \ > > -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \ > > -v RET_ON_FAIL=1 \ > > + -v MESSAGE="$message" \ > > -f $(dirname $(readli

Re: [dpdk-dev] [PATCH v2] devtools: add explicit warning messages for forbidden tokens

2018-11-02 Thread Thomas Monjalon
02/11/2018 07:00, Arnon Warshavsky: > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -49,13 +49,16 @@ check_forbidden_additions() { # > awk -v FOLDERS="lib drivers" \ > -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \ > -v RET_ON_FAIL=1 \ > +

[dpdk-dev] [PATCH v2] devtools: add explicit warning messages for forbidden tokens

2018-11-01 Thread Arnon Warshavsky
Replace the content of warning in the forbidden tokens script from using the searched regex into using explicit messages Signed-off-by: Arnon Warshavsky --- v2 - spelling typo devtools/check-forbidden-tokens.awk | 7 +-- devtools/checkpatches.sh| 3 +++ 2 files changed, 4 inser