[dpdk-dev] [PATCH v2] cryptodev: uninline parameter parsing

2016-06-26 Thread Thomas Monjalon
2016-06-25 15:24, De Lara Guarch, Pablo: > > +DPDK_16.07 { > > + global: > > + > > + rte_cryptodev_parse_vdev_init_params; > > I think this function does not need to be public. > This function is only called in the PMDs, and the only public function > to initialize a crypto device is rte_eal_v

[dpdk-dev] [PATCH v2] cryptodev: uninline parameter parsing

2016-06-25 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Saturday, June 25, 2016 2:14 PM > To: Doherty, Declan; De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: [PATCH v2] cryptodev: uninline parameter parsing > > There is no need to have

[dpdk-dev] [PATCH v2] cryptodev: uninline parameter parsing

2016-06-25 Thread Thomas Monjalon
There is no need to have this parsing inlined in the header. It brings kvargs dependency to every crypto drivers. The functions are moved into rte_cryptodev.c. Signed-off-by: Thomas Monjalon --- v2: - remove kvargs dep in null PMD - add function in .map file --- drivers/crypto/null/Makefile