Re: [dpdk-dev] [PATCH v2] cmdline: rework as a wrapper to libedit

2018-06-27 Thread Olivier Matz
On Wed, Jun 27, 2018 at 11:36:28AM +0100, Bruce Richardson wrote: > On Tue, Jun 26, 2018 at 03:21:21PM +0200, Olivier Matz wrote: > > Hi Adrien, > > > > Better late than never, please find below some comments > > about your patch. > > > > On Thu, Apr 19, 2018 at 05:13:53PM +0200, Adrien Mazarguil

Re: [dpdk-dev] [PATCH v2] cmdline: rework as a wrapper to libedit

2018-06-27 Thread Bruce Richardson
On Tue, Jun 26, 2018 at 03:21:21PM +0200, Olivier Matz wrote: > Hi Adrien, > > Better late than never, please find below some comments > about your patch. > > On Thu, Apr 19, 2018 at 05:13:53PM +0200, Adrien Mazarguil wrote: > > Disclaimer: this patch must not be confused with the CLI library [1]

Re: [dpdk-dev] [PATCH v2] cmdline: rework as a wrapper to libedit

2018-06-26 Thread Olivier Matz
> I noticed a bad behavior change (in addition to many good ones): > ctrl-c now quits the application, and this was not the case before. > I often use ctrl-c to delete the line I'm currently editing. Please > see at the end a proposition to restore this feature. And now, ladies and gentlemen, the

Re: [dpdk-dev] [PATCH v2] cmdline: rework as a wrapper to libedit

2018-06-26 Thread Olivier Matz
Hi Adrien, Better late than never, please find below some comments about your patch. On Thu, Apr 19, 2018 at 05:13:53PM +0200, Adrien Mazarguil wrote: > Disclaimer: this patch must not be confused with the CLI library [1] > (work in progress) that will eventually supersede librte_cmdline itself >

[dpdk-dev] [PATCH v2] cmdline: rework as a wrapper to libedit

2018-04-19 Thread Adrien Mazarguil
Disclaimer: this patch must not be confused with the CLI library [1] (work in progress) that will eventually supersede librte_cmdline itself with a different API. Rather, it modifies librte_cmdline to delegate all the heavy lifting (terminal and history handling), strips unused features and re-imp