Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec

2019-06-09 Thread Zhao1, Wei
Thank you, update in v3. > -Original Message- > From: Iremonger, Bernard > Sent: Friday, June 7, 2019 9:59 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Peng, Yuan ; Yigit, Ferruh > ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: remov

Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec

2019-06-07 Thread Iremonger, Bernard
Hi Wei, > > Subject: [PATCH v2] app/testpmd: remove port stop check for macsec > > > > There is no need to do such a check when set macsec for ixgbe, > > reconfig_device_queueand is also useless. If we do not delete this Typo: space missing before "and" in previous line. > > unnessary code, us

Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec

2019-05-12 Thread Zhao1, Wei
Tested-by: Peng Yuan > -Original Message- > From: Zhao1, Wei > Sent: Friday, May 10, 2019 4:41 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Peng, Yuan ; Yigit, Ferruh > ; Lu, Wenzhuo ; Zhao1, Wei > > Subject: [PATCH v2] app/testpmd: remove port stop check for macsec > > There is no nee

[dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec

2019-05-10 Thread Wei Zhao
There is no need to do such a check when set macsec for ixgbe, reconfig_device_queueand is also useless. If we do not delete this unnessary code, users have to sotp port before enable or disable macsec, then restart this port after make configuration. All these process is useless. As this cmdline i