Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-04-11 Thread Dmitry Kozlyuk
2021-04-02 15:14 (UTC-0700), Jie Zhou: > On Wed, Mar 31, 2021 at 12:10:03PM -0700, Kadam, Pallavi wrote: > > > > On 3/19/2021 9:51 AM, Jie Zhou wrote: > > >From: Jie Zhou [...] > > >--- a/app/test-pmd/testpmd.c > > >+++ b/app/test-pmd/testpmd.c > > >@@ -9,7 +9,9 @@ > > > #include > > > #incl

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-04-11 Thread Dmitry Kozlyuk
Hi Jie, General comment: try to avoid #ifdef RTE_EXEC_ENV_WINDOWS except for inherently non-portable Unix code. It clutters the source and complicates testing: unless you build on Linux you won't know something broke in code under #ifdef. Take device hot-plug for example. Since you disable paramet

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-04-02 Thread Jie Zhou
On Thu, Apr 01, 2021 at 08:44:31AM +, Tal Shnaiderman wrote: > > Subject: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows > > > > From: Jie Zhou > > > > This patch is to enable testpmd on windows. It mainly includes: > > - Enable buildi

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-04-02 Thread Jie Zhou
On Wed, Mar 31, 2021 at 12:10:03PM -0700, Kadam, Pallavi wrote: > > On 3/19/2021 9:51 AM, Jie Zhou wrote: > >From: Jie Zhou > > > >This patch is to enable testpmd on windows. It mainly includes: > >- Enable building libraries on Windows that TestPMD depends on > >- Enable building testpmd on Wind

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-04-01 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows > > From: Jie Zhou > > This patch is to enable testpmd on windows. It mainly includes: > - Enable building libraries on Windows that TestPMD depends on > - Enable building testpmd on Windows > -

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-03-31 Thread Kadam, Pallavi
On 3/19/2021 9:51 AM, Jie Zhou wrote: From: Jie Zhou This patch is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that TestPMD depends on - Enable building testpmd on Windows - Resolve name collisions with Windows types - Add clock_gettime_monotic for

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-03-20 Thread Dmitry Kozlyuk
2021-03-19 09:51 (UTC-0700), Jie Zhou: > Issue under active investigation: > - Recent DPDK upstream change "eal: detach memsegs on cleanup" exposed > failure at eal exit with "EAL: Could not unmap memory: No Error". > Investigating KERNELBASE!UnmapViewOfFile. The issue will cause system > cra

[dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-03-19 Thread Jie Zhou
From: Jie Zhou This patch is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that TestPMD depends on - Enable building testpmd on Windows - Resolve name collisions with Windows types - Add clock_gettime_monotic for testpmd on Windows - Make printf format w