[dpdk-dev] [PATCH v2] Clang compile error with RTE_LIBRTE_MEMPOOL_DEBUG enabled.

2014-10-01 Thread Wiles, Roger Keith
Thomas, I will submit a v3 patch in a few minutes. On Oct 1, 2014, at 9:57 AM, Wiles, Roger Keith wrote: > Hi Thomas, > > Changing the macros to: > > #ifdef RTE_LIBRTE_MEMPOOL_DEBUG > #ifndef __INTEL_COMPILER > #pragma GCC diagnostic ignored "-Wcast-qual" > #endif > . > . > #ifndef __INTEL_CO

[dpdk-dev] [PATCH v2] Clang compile error with RTE_LIBRTE_MEMPOOL_DEBUG enabled.

2014-10-01 Thread Thomas Monjalon
2014-09-28 05:30, Wiles, Roger Keith: > When enabling RTE_LIBRTE_MEMPOOL_DEBUG and compiling with clang > compiler an error occurs, because ifdefed code now includes GCC pragmas. > > GCC 4.4 is when push_options and pop_options pragma show up. > > Signed-off-by: Keith Wiles [...] > -#ifndef __IN

[dpdk-dev] [PATCH v2] Clang compile error with RTE_LIBRTE_MEMPOOL_DEBUG enabled.

2014-10-01 Thread Wiles, Roger Keith
Hi Thomas, Changing the macros to: #ifdef RTE_LIBRTE_MEMPOOL_DEBUG #ifndef __INTEL_COMPILER #pragma GCC diagnostic ignored "-Wcast-qual" #endif . . #ifndef __INTEL_COMPILER #pragma GCC diagnostic error "-Wcast-qual" #endif Works and is a good solution. I normally do not like negative ?ifndef?

[dpdk-dev] [PATCH v2] Clang compile error with RTE_LIBRTE_MEMPOOL_DEBUG enabled.

2014-09-28 Thread Wiles, Roger Keith
When enabling RTE_LIBRTE_MEMPOOL_DEBUG and compiling with clang compiler an error occurs, because ifdefed code now includes GCC pragmas. GCC 4.4 is when push_options and pop_options pragma show up. Signed-off-by: Keith Wiles --- lib/librte_mempool/rte_mempool.h | 4 ++-- 1 file changed, 2 inse