Re: [dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

2020-11-01 Thread David Marchand
On Sun, Nov 1, 2020 at 7:07 PM McDaniel, Timothy wrote: > > Availability of the MOVDIR64B instruction is indicated by the presence > > of the CPUID feature flag MOVDIR64B (bit 28 of the ECX register in > > leaf 07H, see “CPUID—CPU Identification” in the Intel® 64 and IA-32 > > Architectures Softwa

Re: [dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

2020-11-01 Thread McDaniel, Timothy
> -Original Message- > From: David Marchand > Sent: Sunday, November 1, 2020 12:01 PM > To: McDaniel, Timothy > Cc: dev ; Carrillo, Erik G ; Eads, > Gage ; Van Haaren, Harry > ; Jerin Jacob Kollanukkaran > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

2020-11-01 Thread David Marchand
> > > + > > > +static inline void > > > +dlb_movdir64b(void *dest, void *src) > > > +{ > > > + asm volatile(".byte 0x66, 0x0f, 0x38, 0xf8, 0x02" > > > +: > > > +: "a" (dest), "d" (src)); > > > +} > > > > NO! > > We introduced stuff in EAL for this, plea

Re: [dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

2020-11-01 Thread McDaniel, Timothy
> -Original Message- > From: David Marchand > Sent: Saturday, October 31, 2020 4:54 PM > To: McDaniel, Timothy > Cc: dev ; Carrillo, Erik G ; Eads, > Gage ; Van Haaren, Harry > ; Jerin Jacob Kollanukkaran > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

2020-11-01 Thread McDaniel, Timothy
> -Original Message- > From: David Marchand > Sent: Saturday, October 31, 2020 4:54 PM > To: McDaniel, Timothy > Cc: dev ; Carrillo, Erik G ; Eads, > Gage ; Van Haaren, Harry > ; Jerin Jacob Kollanukkaran > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

2020-10-31 Thread David Marchand
On Sat, Oct 31, 2020 at 7:17 PM Timothy McDaniel wrote: > > Add miscellaneous inline functions that may be called > from multiple files. These functions include inline > assembly of new x86 instructions, such as movdir64b, > since they are not available as builtin functions in > the minimum suppo

[dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

2020-10-31 Thread Timothy McDaniel
Add miscellaneous inline functions that may be called from multiple files. These functions include inline assembly of new x86 instructions, such as movdir64b, since they are not available as builtin functions in the minimum supported GCC version. Signed-off-by: Timothy McDaniel Reviewed-by: Gage