On Mon, Sep 10, 2018 at 8:17 AM, Arnon Warshavsky wrote:
> I get some warning when running this on Ubuntu 18.04.
>>
>>
>> marchand@gribouille:~/git/dpdk$ ./devtools/checkpatches.sh
>> sanity/0001-mbuf-add-sanity-checks-on-segment-metadata.patch
>> ./devtools/checkpatches.sh: 52: read: Illegal opti
I get some warning when running this on Ubuntu 18.04.
>
> marchand@gribouille:~/git/dpdk$ ./devtools/checkpatches.sh
> sanity/0001-mbuf-add-sanity-checks-on-segment-metadata.patch
> ./devtools/checkpatches.sh: 52: read: Illegal option -d
>
> Hi,
A patch that fixes that was already sent a few days
On Tue, Jul 31, 2018 at 2:38 PM, Thomas Monjalon wrote:
> 27/07/2018 00:10, Arnon Warshavsky:
>> This patch adds a new function that is called
>> per every checked patch,
>> and alerts for new instances of rte_panic/rte_exit.
>> The check excludes comments, and alerts in the case
>> of a positive
27/07/2018 00:10, Arnon Warshavsky:
> This patch adds a new function that is called
> per every checked patch,
> and alerts for new instances of rte_panic/rte_exit.
> The check excludes comments, and alerts in the case
> of a positive balance between additions and removals.
>
> Signed-off-by: Arno
> + awk -v FOLDERS="lib net drivers" \
>
> I don't know why net is listed as a root directory here?
> I am going to apply the patch without the "net" directory. OK?
>
Yes please. Its not necessarily root rather in any location of the path,
but having added drivers, net is now redundant.
thank
27/07/2018 00:10, Arnon Warshavsky:
> + # refrain from new additions of rte_panic() and rte_exit()
> + # under lib and net
> + # multiple folders and expressions are separated by spaces
> + awk -v FOLDERS="lib net drivers" \
I don't know why net is listed as a root directory here?
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
Test
7 matches
Mail list logo
