Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-22 Thread Ananyev, Konstantin
> > 2016-12-12 11:51, Ananyev, Konstantin: > > > > The application gets few information from tx_prepare() about what should > > > > be done to make the packet accepted by the hw, and the actions will > > > > probably be different depending on hardware. > > > > That's true. > > I am open to suggest

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-22 Thread Jerin Jacob
On Thu, Dec 22, 2016 at 02:14:45PM +0100, Thomas Monjalon wrote: > 2016-12-02 00:10, Ananyev, Konstantin: > > I have absolutely no problem to remove the RTE_ETHDEV_TX_PREPARE and > > associated logic. > > I personally don't use ARM boxes and don't plan to, > > and in theory users can still do cond

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-22 Thread Thomas Monjalon
2016-12-12 11:51, Ananyev, Konstantin: > > > The application gets few information from tx_prepare() about what should > > > be done to make the packet accepted by the hw, and the actions will > > > probably be different depending on hardware. > > That's true. > I am open to suggestions how in futu

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-22 Thread Thomas Monjalon
2016-12-02 00:10, Ananyev, Konstantin: > I have absolutely no problem to remove the RTE_ETHDEV_TX_PREPARE and > associated logic. > I personally don't use ARM boxes and don't plan to, > and in theory users can still do conditional compilation at the upper layer, > if they want to. Yes you're ri

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-12 Thread Ananyev, Konstantin
Hi Olivier and Tomasz, > -Original Message- > From: Kulasek, TomaszX > Sent: Friday, December 9, 2016 5:19 PM > To: Olivier Matz ; Ananyev, Konstantin > > Cc: Thomas Monjalon ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation >

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-09 Thread Kulasek, TomaszX
; > Sent: Friday, December 2, 2016 8:24 AM > > > To: Ananyev, Konstantin > > > Cc: Thomas Monjalon ; Kulasek, TomaszX > > > ; dev@dpdk.org Subject: Re: [dpdk-dev] > > > [PATCH v12 1/6] ethdev: add Tx preparation > > > > > > Hi Konstant

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-09 Thread Kulasek, TomaszX
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, December 2, 2016 00:51 > To: Kulasek, TomaszX > Cc: dev@dpdk.org; Ananyev, Konstantin ; > olivier.m...@6wind.com; Richardson, Bruce > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-08 Thread Olivier Matz
t; > Cc: Thomas Monjalon ; Kulasek, TomaszX > > ; dev@dpdk.org Subject: Re: [dpdk-dev] > > [PATCH v12 1/6] ethdev: add Tx preparation > > > > Hi Konstantin, > > > > On Fri, 2 Dec 2016 01:06:30 +, "Ananyev, Konstantin" > > wrote: &

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-02 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, December 2, 2016 8:24 AM > To: Ananyev, Konstantin > Cc: Thomas Monjalon ; Kulasek, TomaszX > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add T

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-02 Thread Olivier Matz
Hi Konstantin, On Fri, 2 Dec 2016 01:06:30 +, "Ananyev, Konstantin" wrote: > > > > 2016-11-23 18:36, Tomasz Kulasek: > > > +/** > > > + * Process a burst of output packets on a transmit queue of an > > > Ethernet device. > > > + * > > > + * The rte_eth_tx_prepare() function is invoked to p

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Ananyev, Konstantin
> > 2016-11-23 18:36, Tomasz Kulasek: > > +/** > > + * Process a burst of output packets on a transmit queue of an Ethernet > > device. > > + * > > + * The rte_eth_tx_prepare() function is invoked to prepare output packets > > to be > > + * transmitted on the output queue *queue_id* of the Ethe

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Ananyev, Konstantin
om; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation > > > > 2016-12-01 19:20, Kulasek, TomaszX: > > > Hi Thomas, > > > > > > Sorry, I have answered for this question in another thread and I missed > > ab

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Thomas Monjalon
2016-12-01 22:31, Kulasek, TomaszX: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2016-12-01 19:20, Kulasek, TomaszX: > > > Hi Thomas, > > > > > > Sorry, I have answered for this question in another thread and I missed > > about this one. Detailed answer is below. > > > > Yes you

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Kulasek, TomaszX
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Thursday, December 1, 2016 20:52 > To: Kulasek, TomaszX > Cc: dev@dpdk.org; Ananyev, Konstantin ; > olivier.m...@6wind.com; Richardson, Bruce > Subject: Re: [dpd

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Jerin Jacob
On Thu, Dec 01, 2016 at 08:52:22PM +0100, Thomas Monjalon wrote: > 2016-12-01 19:20, Kulasek, TomaszX: > > Hi Thomas, > > > > Sorry, I have answered for this question in another thread and I missed > > about this one. Detailed answer is below. > > Yes you already gave this answer. > And I will c

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Thomas Monjalon
2016-12-01 19:20, Kulasek, TomaszX: > Hi Thomas, > > Sorry, I have answered for this question in another thread and I missed about > this one. Detailed answer is below. Yes you already gave this answer. And I will continue asking the question until you understand it. > > 2016-11-28 11:54, Thoma

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Kulasek, TomaszX
X > Cc: dev@dpdk.org; Ananyev, Konstantin ; > olivier.m...@6wind.com; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation > > Please, a reply to this question would be greatly appreciated. > > 2016-11-28 11:54, Thomas Monjalon: > > Hi, &

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Thomas Monjalon
2016-11-23 18:36, Tomasz Kulasek: > +/** > + * Process a burst of output packets on a transmit queue of an Ethernet > device. > + * > + * The rte_eth_tx_prepare() function is invoked to prepare output packets to > be > + * transmitted on the output queue *queue_id* of the Ethernet device > desig

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Thomas Monjalon
2016-11-23 18:36, Tomasz Kulasek: > Added fields to the `struct rte_eth_desc_lim`: > > uint16_t nb_seg_max; > /**< Max number of segments per whole packet. */ > > uint16_t nb_mtu_seg_max; > /**< Max number of segments per one MTU */ How (and when) an appli

Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-12-01 Thread Thomas Monjalon
Please, a reply to this question would be greatly appreciated. 2016-11-28 11:54, Thomas Monjalon: > Hi, > > 2016-11-23 18:36, Tomasz Kulasek: > > --- a/config/common_base > > +++ b/config/common_base > > @@ -120,6 +120,7 @@ CONFIG_RTE_MAX_QUEUES_PER_PORT=1024 > > CONFIG_RTE_LIBRTE_IEEE1588=n > >

[dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-11-28 Thread Thomas Monjalon
Hi, 2016-11-23 18:36, Tomasz Kulasek: > --- a/config/common_base > +++ b/config/common_base > @@ -120,6 +120,7 @@ CONFIG_RTE_MAX_QUEUES_PER_PORT=1024 > CONFIG_RTE_LIBRTE_IEEE1588=n > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16 > CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y > +CONFIG_RTE_ETHDEV_TX_PREPARE=y Pl

[dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation

2016-11-23 Thread Tomasz Kulasek
Added API for `rte_eth_tx_prepare` uint16_t rte_eth_tx_prepare(uint8_t port_id, uint16_t queue_id, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) Added fields to the `struct rte_eth_desc_lim`: uint16_t nb_seg_max; /**< Max number of segments per whole packet. */