Re: [dpdk-dev] [PATCH v12] ethdev: new Rx/Tx offloads API

2018-05-14 Thread Dai, Wei
mailto:tho...@monjalon.net] > Sent: Monday, May 14, 2018 4:37 PM > To: Dai, Wei > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v12] ethdev: new Rx/Tx offloads API > > Wei Dai, > Do you agree with my comments? > Could we have a wording patch to sq

Re: [dpdk-dev] [PATCH v12] ethdev: new Rx/Tx offloads API

2018-05-14 Thread Thomas Monjalon
Wei Dai, Do you agree with my comments? Could we have a wording patch to squash in RC3? 10/05/2018 23:39, Thomas Monjalon: > Hi, > > A first general comment: a lot of spaces are still inside parens. > You can grep '( )'. > > 10/05/2018 13:56, Wei Dai: > > --- a/doc/guides/prog_guide/poll_mode_d

Re: [dpdk-dev] [PATCH v12] ethdev: new Rx/Tx offloads API

2018-05-10 Thread Ferruh Yigit
On 5/10/2018 12:56 PM, Wei Dai wrote: > This patch check if a input requested offloading is valid or not. > Any reuqested offloading must be supported in the device capabilities. > Any offloading is disabled by default if it is not set in the parameter > dev_conf->[rt]xmode.offloads to rte_eth_dev_

Re: [dpdk-dev] [PATCH v12] ethdev: new Rx/Tx offloads API

2018-05-10 Thread Thomas Monjalon
Hi, A first general comment: a lot of spaces are still inside parens. You can grep '( )'. 10/05/2018 13:56, Wei Dai: > --- a/doc/guides/prog_guide/poll_mode_drv.rst > +++ b/doc/guides/prog_guide/poll_mode_drv.rst > +A per-queue offloading can be enabled on a queue and disabled on another > queue

[dpdk-dev] [PATCH v12] ethdev: new Rx/Tx offloads API

2018-05-10 Thread Wei Dai
This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_configure() and [rt]x_conf->offloads to rte_et