>
> One more nit: the title says "additions/removals" but the function is
> only about additions.
>
>
> Yup. No removals there..
> 16/07/2018 14:44, Arnon Warshavsky:
> > + ! $verbose || printf '\nChecking forbidden tokens additions/removals:\n'
> > + report=$(cat $tmpinput | check_forbidden_additions)
One more nit: the title says "additions/removals" but the function is
only about additions.
> > + read -d '' awk_script << 'EOF'
>
> EOF must be quoted?
>
Missed that one. Yes, the quotes are there to prevent parameter expansion
of the awk variables.
The script breaks without them
26/07/2018 22:57, Arnon Warshavsky:
> > > + if [ $? -ne 0 ] ; then
> > > + ret=1
> > > + fi
> > > + printf '%s\n' "$report"
> >
> > You are printing the report, no matter of the result? Why?
> > Is it because a warning does not return as an error?
> >
> There is maybe an imp
> > +check_forbidden_additions() { #
>
> This function looks to work with stdin, not a file.
> Better to remove the comment about a .
>
It can actually work with both but you are right. The comment is not
beneficial there
Will fix with the rest of the list below
...
>
> > + if [ $? -ne 0 ]
Hi,
I am sorry, I always give low priority to tooling review.
I was going to apply this one, but I've seen some details to improve.
16/07/2018 14:44, Arnon Warshavsky:
> +check_forbidden_additions() { #
This function looks to work with stdin, not a file.
Better to remove the comment about a .
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
Test
7 matches
Mail list logo
