Re: [dpdk-dev] [PATCH v10 1/3] lib: add Generic Receive Offload API framework

2017-07-04 Thread Hu, Jiayu
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Tuesday, July 4, 2017 4:37 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Ananyev, Konstantin ; > step...@networkplumber.org; Tan, Jianfeng ; Wu, > Jingjing ; Yao, Lei A ; Bie, > Tiwei > Subject: Re: [PATC

Re: [dpdk-dev] [PATCH v10 1/3] lib: add Generic Receive Offload API framework

2017-07-04 Thread Yuanhan Liu
Haven't looked at the details yet, and below are some quick comments after a glimpse. On Sat, Jul 01, 2017 at 07:08:41PM +0800, Jiayu Hu wrote: ... > +void *rte_gro_tbl_create(const > + const struct rte_gro_param *param) The DPDK style is: void * rte_gro_tbl_destroy(...) Also you sh

Re: [dpdk-dev] [PATCH v10 1/3] lib: add Generic Receive Offload API framework

2017-07-04 Thread Yuanhan Liu
On Mon, Jul 03, 2017 at 05:56:20AM +, Hu, Jiayu wrote: > > > +/** > > > + * GRO table, which is used to merge packets. It keeps many reassembly > > > + * tables of desired GRO types. Applications need to create GRO tables > > > + * before using rte_gro_reassemble to perform GRO. > > > + */ > >

Re: [dpdk-dev] [PATCH v10 1/3] lib: add Generic Receive Offload API framework

2017-07-02 Thread Hu, Jiayu
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Sunday, July 2, 2017 6:20 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; > step...@networkplumber.org; y...@fridaylinux.org; Wu, Jingjing > ; Yao, Lei A ; Bie, Tiwei > > Subject: Re: [PATCH v10 1/3] lib: add Ge

Re: [dpdk-dev] [PATCH v10 1/3] lib: add Generic Receive Offload API framework

2017-07-02 Thread Tan, Jianfeng
On 7/1/2017 7:08 PM, Jiayu Hu wrote: Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this patch imp

[dpdk-dev] [PATCH v10 1/3] lib: add Generic Receive Offload API framework

2017-07-01 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this patch implements a GRO API framework. To enable m